Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obtain fellows from People Chain #30

Merged
merged 11 commits into from
Jul 29, 2024
Merged

Obtain fellows from People Chain #30

merged 11 commits into from
Jul 29, 2024

Conversation

Bullrich
Copy link
Contributor

@Bullrich Bullrich commented Jul 26, 2024

Do we have to commit this?
I think it is not needed anymore
Polkadot-API depends on some dependencies that `ncc` is not bundling together so we need to keep the `node_modules` (like `@polkadot-api/metadata-compatibility`)
We use a different change so this is a minor update
@Bullrich Bullrich self-assigned this Jul 26, 2024
@Bullrich Bullrich requested a review from a team as a code owner July 26, 2024 11:00
@Bullrich
Copy link
Contributor Author

@mutantcornholio I think we will have to remove the immutable from the installation step as the "files" inside the papi directory uses the workspace as part of the hash:

➤ YN0028: - resolution: "@polkadot-api/descriptors@file:.papi/descriptors#.papi/descriptors::hash=8e5d63&locator=get-fellows-action%40workspace%3A."
➤ YN0028: + resolution: "@polkadot-api/descriptors@file:.papi/descriptors#.papi/descriptors::hash=dfa29b&locator=get-fellows-action%40workspace%3A."
➤ YN0028: - checksum: 10c0/1d1a20c19957b0ebebcdea59306a0d2beed23324d0d11d061cb04a3725bee279771d7a019d7914eee9b6304ba40403a1d0cb0e379cab1c1f7b3c86886a529d79

Bullrich added a commit to paritytech/review-bot that referenced this pull request Jul 26, 2024
@mutantcornholio
Copy link
Contributor

@Bullrich try removing papi from postinstall and invoke it as a separate step

@Bullrich
Copy link
Contributor Author

@Bullrich try removing papi from postinstall and invoke it as a separate step

I tried that with 9aaa35c but doesn't seem to be working

@mutantcornholio mutantcornholio merged commit 4505976 into main Jul 29, 2024
8 checks passed
@mutantcornholio mutantcornholio deleted the people-chain branch July 29, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CI for Polkadot People Chain Update to use People Chain
2 participants