Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update subxt #697

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Update subxt #697

merged 2 commits into from
Apr 19, 2024

Conversation

AndreiEres
Copy link
Collaborator

@AndreiEres AndreiEres commented Apr 19, 2024 •
edited
Loading

  • Update subxt
  • Removed using dyn since OnlineClient can be built from LightClientRpc.

@AndreiEres AndreiEres requested a review from lexnv April 19, 2024 10:29
lexnv
lexnv approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@lexnv lexnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice one 👍

@AndreiEres AndreiEres merged commit ea2ba20 into master Apr 19, 2024
5 checks passed
@AndreiEres AndreiEres deleted the AndreiEres/update-subxt branch April 19, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lexnv lexnv lexnv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndreiEres @lexnv