Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
  • Loading branch information
dastansam and ggwpez authored Apr 17, 2024
1 parent e12b45f commit d9efe90
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion prdoc/pr_4020.prdoc
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ doc:
`RuntimeBlockWeights` for `DispatchClass::Normal` type extrinsics.

During benchmark execution developers can either choose to throw an error, log a warning, or ignore if the weight exceeds the limit. Default behaviour is
warning. This can be configured by passing an argument to `--sanity-check` flag in the benchmarking CLI.
warning. This can be configured by passing an argument to `--sanity-weight-check` flag in the benchmarking CLI.

Note: This introduces a breaking change for `frame_benchmarking::Benchmark` runtime API. `benchmark_metadata` function now returns new struct `RuntimeBenchmarkInfo`
that encapsulates exhaustive benchmarks related information. To ensure backwards compatibility, `RuntimeBenchmarkInfo` can be created from previous
Expand Down
2 changes: 1 addition & 1 deletion substrate/utils/frame/benchmarking-cli/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ chrono = "0.4"
clap = { version = "4.5.3", features = ["derive"] }
codec = { package = "parity-scale-codec", version = "3.6.1" }
comfy-table = { version = "7.1.0", default-features = false }
handlebars = "5.1.0"
handlebars = "5.1.0"
Inflector = "0.11.4"
itertools = "0.10.3"
lazy_static = "1.4.0"
Expand Down

0 comments on commit d9efe90

Please sign in to comment.