Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check all benchmark results #6722

Open
athei opened this issue Dec 1, 2024 · 5 comments
Open

Check all benchmark results #6722

athei opened this issue Dec 1, 2024 · 5 comments

Comments

@athei
Copy link
Member

athei commented Dec 1, 2024

Before releasing on any value bearing chain we need to make sure that all benchmark results and hence weights do make sense.

@athei athei converted this from a draft issue Dec 1, 2024
@mordamax
Copy link
Contributor

mordamax commented Dec 8, 2024

@athei related / similar to #6196 ?

@athei
Copy link
Member Author

athei commented Dec 9, 2024

This is more than just running the benchmarks. We did a lot of changes to the pallet without paying much attention to the benchmarks. I need to go through them and make sure they make sense. Some of them need to be reworked like #6157

@mordamax
Copy link
Contributor

mordamax commented Dec 9, 2024

@athei would #6196 bring any problems or should be ok?

@athei
Copy link
Member Author

athei commented Dec 9, 2024

Thats okay. Just re-running the benchmarks should not break anything. Production chains will have their own benchmarks anyways.

@kianenigma
Copy link
Contributor

#5792 related issues about generally having correct weights across the board.

Parachains should generally have "correct" weights at all times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Minimal Feature Launch
Development

No branches or pull requests

3 participants