Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Identity trait to frame prelude or the umbrella crate #7112

Open
seemantaggarwal opened this issue Jan 10, 2025 · 0 comments
Open

Migrate Identity trait to frame prelude or the umbrella crate #7112

seemantaggarwal opened this issue Jan 10, 2025 · 0 comments

Comments

@seemantaggarwal
Copy link
Contributor

As seen during pallet migrations in here : #6504

The current implementation of the Identity trait in the prelude breaks as the trait Convert<u64, u64> is not implemented for polkadot_sdk_frame::prelude::Identity, which is required by ConvertRank<polkadot_sdk_frame::prelude::Identity>: polkadot_sdk_frame::traits::tokens::GetSalary<u64, u64, u64>

sp_runtime::{traits::Identity} needs to migrated to umbrella crate

See error run here:
https://github.com/paritytech/polkadot-sdk/actions/runs/12674245840/job/35322600536

and here:

https://github.com/paritytech/polkadot-sdk/actions/runs/12667087673/job/35299831553

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant