sp-std -> core #3199
Merged
sp-std -> core #3199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kianenigma
reviewed
Feb 4, 2024
kianenigma
approved these changes
Feb 4, 2024
There was a problem hiding this comment.
I am glad we are doing this step by step.
As noted in #2101, I am not super convinced that the whole deprecation is a winning tradeoff, but I am too late to that conversation 🎩
|
There is merit in just doing all the core references (there are a lot of |
gilescope
requested review from
athei,
acatangiu,
andresilva,
a team and
koute
as code owners
|
ok that set of changes looks good to me. |
athei
approved these changes
Feb 6, 2024
davxy
approved these changes
Feb 6, 2024
koute
approved these changes
Feb 6, 2024
Merged
via the queue into
paritytech:master
with commit Feb 6, 2024
bc2e5e1
129 of 131 checks passed
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this pull request
Mar 25, 2024
First in a series of PRs that reduces our use of sp-std with a view to deprecating it. This is just looking at /substrate and moving some of the references from `sp-std` to `core`. These particular changes should be uncontroversial. Where macros are used `::core` should be used to remove any ambiguity. part of paritytech#2101
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First in a series of PRs that reduces our use of sp-std with a view to deprecating it.
This is just looking at /substrate and moving some of the references from
sp-stdtocore.These particular changes should be uncontroversial.
Where macros are used
::coreshould be used to remove any ambiguity.part of #2101