Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove getters from im-online pallet #3589

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

s0me0ne-unkn0wn
Copy link
Contributor

@s0me0ne-unkn0wn s0me0ne-unkn0wn commented Mar 6, 2024

As I've been dancing around this pallet for quite some time anyway, I decided to remove getters at once. There were only a few leftovers in tests.

Related: #3326
CC @muraca

@s0me0ne-unkn0wn s0me0ne-unkn0wn added R0-silent Changes should not be mentioned in any release notes T2-pallets This PR/Issue is related to a particular pallet. labels Mar 6, 2024
@s0me0ne-unkn0wn s0me0ne-unkn0wn marked this pull request as ready for review March 6, 2024 09:45
@s0me0ne-unkn0wn s0me0ne-unkn0wn requested a review from a team as a code owner March 6, 2024 09:45
Copy link
Contributor

@muraca muraca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
This is a breaking change though, so please remove the R0 label and add the prdoc

@s0me0ne-unkn0wn s0me0ne-unkn0wn removed the R0-silent Changes should not be mentioned in any release notes label Mar 6, 2024
@s0me0ne-unkn0wn s0me0ne-unkn0wn requested a review from muraca March 6, 2024 15:30
@s0me0ne-unkn0wn s0me0ne-unkn0wn added this pull request to the merge queue Mar 11, 2024
Merged via the queue into master with commit 4249a3d Mar 11, 2024
137 of 138 checks passed
@s0me0ne-unkn0wn s0me0ne-unkn0wn deleted the s0me0ne/remove-getters-im-online branch March 11, 2024 15:12
dharjeezy pushed a commit to dharjeezy/polkadot-sdk that referenced this pull request Mar 24, 2024
As I've been dancing around this pallet for quite some time anyway, I
decided to remove getters at once. There were only a few leftovers in
tests.

Related: paritytech#3326 
CC @muraca
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
As I've been dancing around this pallet for quite some time anyway, I
decided to remove getters at once. There were only a few leftovers in
tests.

Related: paritytech#3326 
CC @muraca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T2-pallets This PR/Issue is related to a particular pallet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants