Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmarking: complete automatic weight sanity check PR #4020

Open
wants to merge 31 commits into
base: master
Choose a base branch
from
Open

benchmarking: complete automatic weight sanity check PR #4020

wants to merge 31 commits into from
+511 −157

Conversation

dastansam
Copy link
Contributor

@dastansam dastansam commented Apr 8, 2024 •
edited
Loading

should complete #1493
polkadot address: 16FqwPZ8GRC5U5D4Fu7W33nA55ZXzXGWHwmbnE1eT6pxuqcT

@dastansam dastansam changed the title Resolve comments and add prdoc benchmarking: complete automatic weight sanity check PR Apr 8, 2024
@dastansam dastansam marked this pull request as ready for review April 8, 2024 00:59
@dastansam dastansam requested a review from a team as a code owner April 8, 2024 00:59
@paritytech-review-bot paritytech-review-bot bot requested a review from a team April 11, 2024 20:42
@dastansam dastansam requested a review from ggwpez April 11, 2024 20:42
@dastansam dastansam changed the base branch from daan/built_in_weight_test to master April 12, 2024 08:57
ggwpez
ggwpez reviewed Apr 15, 2024
View reviewed changes
prdoc/pr_4020.prdoc Outdated Show resolved Hide resolved
ggwpez
ggwpez approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to approve since its technically correct, just some small improvements possible.

@github-actions github-actions bot requested a review from ggwpez April 15, 2024 18:33
@dastansam
Copy link
Contributor Author

Going to approve since its technically correct, just some small improvements possible.

comments are resolved: most of the logs are removed/simplified and logged only for failing extrinsics

@dastansam
Copy link
Contributor Author

@ggwpez could you review it one last time?

ggwpez
ggwpez reviewed Apr 17, 2024
View reviewed changes
prdoc/pr_4020.prdoc Outdated Show resolved Hide resolved
ggwpez
ggwpez approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. cc @kianenigma in case you also want to take a look.

@dastansam @ggwpez
Apply suggestions from code review
d9efe90 
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@dastansam
Copy link
Contributor Author

hey @kianenigma would appreciate your review on this. thanks!

@dastansam
Copy link
Contributor Author

hey @kianenigma would appreciate your review on this. thanks!

@kianenigma ping

kianenigma
kianenigma reviewed Jan 10, 2025
View reviewed changes
Copy link
Contributor

@kianenigma kianenigma left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see this completed!

Can it be done without breaking the API?

@ggwpez just worried if this will again introduce another versioing issue with omni bencher and runtimes out there. Some runtimes will not work because they are not up to date, etc etc.

Tbh if that is the case, I don't think this feature is worth it.

Ideally it can be added incrementally, as a new runtime api.

In any case @dastansam great job and I will issue a tip.

@kianenigma
Copy link
Contributor

/tip medium

@substrate-tip-bot substrate-tip-bot
Copy link

@kianenigma A referendum for a medium (80 DOT) tip was successfully submitted for @dastansam (16FqwPZ8GRC5U5D4Fu7W33nA55ZXzXGWHwmbnE1eT6pxuqcT on polkadot).

Referendum number: 1378.
tip

@substrate-tip-bot substrate-tip-bot
Copy link

The referendum has appeared on Polkassembly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kianenigma kianenigma kianenigma left review comments

@ggwpez ggwpez ggwpez approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dastansam @paritytech-cicd-pr @kianenigma @ggwpez @Daanvdplas