-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
omni-node: --dev sets manual seal and allows --chain to be set #6646
Merged
iulianbarbu
merged 25 commits into
paritytech:master
from
iulianbarbu:ib-dev-flag-with-manual-seal
Dec 10, 2024
Merged
Changes from 9 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
9eab6a1
omni-node: --dev starts manual seal and allows --chain to be set
iulianbarbu e321830
comments fixes
iulianbarbu 922285c
fix comments
iulianbarbu c5838ce
add prdoc
iulianbarbu 61fda5c
Merge branch 'master' into ib-dev-flag-with-manual-seal
iulianbarbu 8b923a8
fix prdoc
iulianbarbu 3e96f98
add docs and fix clippy
iulianbarbu dbb1d1e
fix doc test
iulianbarbu 6f9e5e8
prdoc fix
iulianbarbu ff46e59
Merge branch 'master' into ib-dev-flag-with-manual-seal
iulianbarbu 897ea81
a few more docs
iulianbarbu f913cec
add choptsticks guide
iulianbarbu 8813409
Merge branch 'master' into ib-dev-flag-with-manual-seal
iulianbarbu f696909
no need to use allow-unresolved-imports
iulianbarbu 06bbd5e
remake dev-block-time standalone
iulianbarbu d6faae7
polish public docs
iulianbarbu 7210dc9
Update cumulus/polkadot-omni-node/lib/src/cli.rs
iulianbarbu 1833acd
fix fmt
iulianbarbu d8395bb
Merge branch 'master' into ib-dev-flag-with-manual-seal
iulianbarbu 405485a
test-stable without cache
iulianbarbu 5d32b16
revert MinimumPeriod
iulianbarbu 4729516
fix clippy
iulianbarbu 81bd3eb
Revert "test-stable without cache"
iulianbarbu 14cbdb4
Merge branch 'master' into ib-dev-flag-with-manual-seal
iulianbarbu c8c1bd2
Merge branch 'master' into ib-dev-flag-with-manual-seal
iulianbarbu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ouf of curiosity - why this was set to 0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At first, it seemed I couldn't run the parachain runtime based chain spec with chopsticks because of an error which IIRC stated that: "Timestamp slot must match
CurrentSlot
. This likely means that the configured block time in the node and/or rest of the runtime is not compatible with Aura'sSlotDuration
". After reading the code for a bit I thought it might have to do with theMinimumPeriod
, which I changed toSLOT_DURATION / 2
, resulting in the newly generated chain spec to work withchopsticks
. I don't remember if at that time though I validated that changing the minimum period back to 0 and rebuilding everything made chopsticks fail again. Then rebuilding the runtime at a later day made things work without theMinimumPeriod
change. I also tested this right now (removed the previous target folder) and things work as expected without the minimum period change. It might have been some inconsistent local state with my artifacts that caused the issue, but this begs for ensuring that the commands we recommend in the READMEs work in CI. Opened this: #6837.