-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metadata/v15: Collect transaction extensions by versions into custom metadata #6755
Closed
+60
−12
Closed
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
9ed7d7c
metadata-ir: Move transaction version extension in dedicated fn
lexnv 92f1e17
metadata/v15: Collect transaction extensions by versions into custom
lexnv 58616c7
metadata-ir/types: Add type for tx by version
lexnv 19894a4
frame/tests: Check custom fields in v15
lexnv d5070f6
frame/tests: Collect values
lexnv d378398
prdoc: Add doc
lexnv bdba0d9
frame/tests: Fix indexing
lexnv cc6a03f
Merge remote-tracking branch 'origin/master' into lexnv/extr-vers
lexnv 364dde6
frame/tests: Place [] around items
lexnv 0d00f50
frame/tests: Import encode
lexnv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
title: Collect transaction extensions by versions into custom metadata for v15 | ||
|
||
doc: | ||
- audience: [ Node Dev, Node Operator ] | ||
description: | | ||
This PR collects the transaction_extensions_by_version type information into the metadata V15 custom types. | ||
This ensures the V15 contains enough information to work with multiple transaction extensions. The meaning of this field is identical to the one collected by the V16 unstable. | ||
It includes indexes of extrinsics from the signed_extension field of the extrinsic metadata. | ||
|
||
crates: | ||
- name: sp-metadata-ir | ||
bump: patch | ||
- name: frame-support-test | ||
bump: none |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is enough, this encode the transaction extension indices used for each version.
But the v15 metadata extensions doesn't contains all the extensions.
If we have 2 version. v15 metadata will contains the first version only.
so we need to add in custom metadata all the other transaction extension, or just all the transaction extensions same as v16.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, this will no longer work when we include new transactions in the next version.
We collect the same transaction extensions (signed extensions), but that will not be the case in the future. I'll introduce the transaction extensions as well, thanks for pointing this out 🙏