migrate pallet-node-authorization to use umbrella crate

[UtkarshBhardwaj007]

Description

Migrate pallet-node-authorization to use umbrella crate. Part of #6504

Review Notes

• This PR migrates pallet-node-authorization to use the umbrella crate.
• Some imports like below have not been added to any prelude as they have very limited usage across the various pallets.

use sp_core::OpaquePeerId as PeerId;

• Added a commonly used runtime trait for testing in the testing_prelude in substrate/frame/src/lib.rs:

pub use sp_runtime::traits::BadOrigin;

• weights.rs uses the weights_prelude like:

use frame::weights_prelude::*;

• tests.rs and mock.rs use the testing_prelude:

use frame::testing_prelude::*;

• lib.rs uses the main prelude like:

use frame::prelude::*;

• For testing: Checked that local build works and tests run successfully.

[re-gius]

The whole issue is marked as R0-silent, as well as this PR, so we don't need a PRdoc unless you do something more than just the migration.

[kianenigma]

To be pedantic, we are only adding new types to frame, and adding things is still worthy of PRDoc and minor upgrade based on semver rules.

If we have merged some PRs already in this direction without PRDoc, it is okay since this crate is quite fresh, but going forward they should have PRDoc.

pallet-node-authorization should not be minor afaik, and since nothing is changing, it is a patch.

[kianenigma]

@ggwpez can you please double check I am not wrong?

[UtkarshBhardwaj007]

I have been creating prdocs for the 2 PRs I have raised for this issue. My reasoning was that even though the changes in pallets could be argued to be none but adding new re-exports in the umbrella pallet must be a minor change.

pallet-node-authorization should not be minor afaik, and since nothing is changing, it is a patch.

I thought about this. I checked the SemVer documnetation and it seems like the recommedation for patch is specifically for bug fixes. Any changes to internal private functions could thus be categorised as minor. Since we are basically just changing imports and internal dependencies, I thought minor to be most accurate here. Curious to hear your thoughts @kianenigma @re-gius @ggwpez .

[kianenigma]

Your description sounds more educated than mine, and I trust it more here :) so minor for both sounds good to me.