release: unset SKIP_WASM_BUILD #7074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
alvicsam
approved these changes
Jan 7, 2025
iulianbarbu
added
R1-breaking_change
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
pepoviola
approved these changes
Jan 7, 2025
seadanda
approved these changes
Jan 7, 2025
Merged
via the queue into
paritytech:master
with commit Jan 7, 2025
a578052
203 of 205 checks passed
iulianbarbu
added
the
A4-needs-backport
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-7074-to-stable2407
git worktree add --checkout .worktree/backport-7074-to-stable2407 backport-7074-to-stable2407
cd .worktree/backport-7074-to-stable2407
git reset --hard HEAD^
git cherry-pick -x a5780527041e39268fc8b05b0f3d098cde204883
git push --force-with-lease |
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-7074-to-stable2409
git worktree add --checkout .worktree/backport-7074-to-stable2409 backport-7074-to-stable2409
cd .worktree/backport-7074-to-stable2409
git reset --hard HEAD^
git cherry-pick -x a5780527041e39268fc8b05b0f3d098cde204883
git push --force-with-lease |
|
Git push to origin failed for stable2412 with exitcode 1 |
iulianbarbu
had a problem deploying
to
subsystem-benchmarks
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Seems like I added
SKIP_WASM_BUILD=1💀 for arch64 binaries, which results in various errors like: #6966. This PR unsets the variable.Closes #6966.
Integration
People who found workarounds as in #6966 can consume the fixed binaries again.
Review Notes
I introduced SKIP_WASM_BUILD=1 for some reason for aarch64 (probably to speed up testing) and forgot to remove it. It slipped through and interfered with
stable2412release artifacts. Needs backporting tostable2412and then rebuilding/overwriting the aarch64 artifacts.