You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The unstable-light-client feature does not unsubscribe from subscriptions.
This behavior leads to subscriptions living forever.
In the context of the chainHead this could be detrimental and could lead in the future to users not being able to subscribe anymore. This is because the chainHead spec states that at least 2 subscriptions should be supported by the server per connection.
test light_client::light_client_testing has been running for over 60 seconds
2024-01-26T13:44:24.492595Z WARN subxt-light-client-background: Subscription response id=1 chain=ChainId(0) is not tracked
2024-01-26T13:44:30.816682Z WARN subxt-light-client-background: Subscription response id=1 chain=ChainId(0) is not tracked
2024-01-26T13:44:36.269689Z WARN subxt-light-client-background: Subscription response id=1 chain=ChainId(0) is not tracked
2024-01-26T13:44:42.308706Z WARN subxt-light-client-background: Subscription response id=1 chain=ChainId(0) is not tracked
2024-01-26T13:44:48.451372Z WARN subxt-light-client-background: Subscription response id=1 chain=ChainId(0) is not tracked
2024-01-26T13:44:48.616638Z WARN subxt-light-client-background: Subscription response id=1 chain=ChainId(0) is not tracked
2024-01-26T13:44:54.568271Z WARN subxt-light-client-background: Subscription response id=1 chain=ChainId(0) is not tracked
2024-01-26T13:45:00.501182Z WARN subxt-light-client-background: Subscription response id=1 chain=ChainId(0) is not tracked
In the following code, the RPC unsubscribe method name is ignored:
To mitigate this extend the background protocol to utilize the unsubscribe method.
Whenever the user drops the subscription in the frontend, the backend should initiate a call to the unsubscribe_method.
Because the request to the unsubscribe_method does not have a frontend user associated with; its response should be logged and dropped.
The text was updated successfully, but these errors were encountered:
The unstable-light-client feature does not unsubscribe from subscriptions.
This behavior leads to subscriptions living forever.
In the context of the
chainHead
this could be detrimental and could lead in the future to users not being able to subscribe anymore. This is because thechainHead
spec states that at least 2 subscriptions should be supported by the server per connection.This has been tested locally with the: #1400
In the following code, the RPC unsubscribe method name is ignored:
subxt/subxt/src/client/light_client/rpc.rs
Lines 105 to 109 in 4408a8c
To mitigate this extend the background protocol to utilize the unsubscribe method.
Whenever the user drops the subscription in the frontend, the backend should initiate a call to the
unsubscribe_method
.Because the request to the
unsubscribe_method
does not have a frontend user associated with; its response should be logged and dropped.The text was updated successfully, but these errors were encountered: