Migrate custom error trait impls to thiserror
#1856
Conversation
core/src/events.rs
Outdated
| @@ -376,7 +376,8 @@ impl<T: Config> EventDetails<T> { | |||
| .map(|f| scale_decode::Field::new(f.ty.id, f.name.as_deref())); | |||
|
|
|||
| let decoded = | |||
| scale_value::scale::decode_as_fields(bytes, &mut fields, self.metadata.types())?; | |||
| scale_value::scale::decode_as_fields(bytes, &mut fields, self.metadata.types()) | |||
| .map_err(Into::<scale_decode::Error>::into)?; | |||
There was a problem hiding this comment.
I'm curious what has changed that makes these new .map_errs necessary?
There was a problem hiding this comment.
decode_as_fields returns DecodeError and although scale_decode::Error implements From<DecodeError> compiler needs an explicit cast
There was a problem hiding this comment.
I don't get why that would be the case though offhand, when it wasn't before? Also, out of interest, can you use Into::into or do you need the explicit type there too?
There was a problem hiding this comment.
No idea either.
Fails to infer the type without explicit annotation
There was a problem hiding this comment.
I had a look and there was a missing From impl for scale_decode::visitor::DecodeError (confusingly similar name!); adding that let the Into's go away :)
Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com>
There was a problem hiding this comment.
Looks good to me.
Would be good if you could double-check whether we should use #[error(transparent)] from every wrapped error type to avoid duplicate stuff in the display impl.
Such Decode error: Decode error <some message> but I'm not sure I could be wrong :P
Description
Migrates Error trait impls to
thiserroras it now supports nostd