-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align toml properties for backward compatibility #117
Comments
A few things I noticed are not backwards compatible: # doesn't work:
[[relaychain.node_groups]]
count = 2
# workaround:
[[relaychain.nodes]]
name = "node-0"
[[relaychain.nodes]]
name = "node-1"
# doesn't work
[parachains.collator]
# workaround:
[[parachains.collators]]
# doesn't work
[relaychain.genesis.runtimeGenesis.patch.configuration.config] |
This PR lists some issues and suggested fixes for them (feel free to pick them up separately and close this PR): In addition to issues outlined in #117 (comment), here are some issues spotted when writing https://github.com/paritytech/disabling-e2e-tests: - runtime genesis patch is applied incorrectly (extra `/genesis` pointer shouldn't be added) - malus accepts [subcommands](https://github.com/paritytech/polkadot-sdk/blob/4c0e0e071355c1048d75fba538c96c35ac743547/polkadot/zombienet_tests/functional/0008-dispute-old-finalized.toml#L25), having a command with spaces not supported, so I added a subcommand support - some types need to be exported in order to be able to reuse setup/helper functions across multiple tests - test cleanup doesn't always work (zombie polkadot processes - not fixed here) --------- Co-authored-by: Javier Viola <363911+pepoviola@users.noreply.github.com>
Thanks for your feedback @ordian :) We decide to not port the Thx! |
I think node groups is a cleaner syntax than manually specifying nodes when you need > 3 nodes and avoid typical copy-paste mistakes. But it's more of nice-to-have than a needed feature :) |
Great, thanks for your feedback. I will tracking as |
While testing some existing
toml
s from Polkadot-sdk it came to our attention that there are properties on the toml that should be (?) optional in order to allow SDK to backwards work with existing toml files and tests;An example is one of the simpliest tomls;
In order to try to spawn this network the following properties had to be (erroneously) added:
[settings]
)[relaychain]
)[[relaychain.nodes]]
)[[parachains]]
)We need to test that our code supports backward tests
The text was updated successfully, but these errors were encountered: