Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[config] change relay/para builders to be more explicit and less confusing. #217

Open
pepoviola opened this issue May 16, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@pepoviola
Copy link
Collaborator

Currently we have with_node (in relay) and with_collator (in para) but the node is by default a validator and can be confusing. To reduce the friction we should:

In relay builder:
add:
with_validator (make authority, pass --validator flag)
change:
add_node (full node)

In para builder:
add:
add_node (full node)
change:
with_collator (make authority, pass --collator flag)

And remove the methods that allow to set the role of the node.


cc: @bkchr

@pepoviola pepoviola self-assigned this Dec 12, 2024
@pepoviola pepoviola added the enhancement New feature or request label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant