Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run fields_mismatch against static_schema data also #1123

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Jan 20, 2025

Fixes #XXXX.

Description

Don't cast floats as int on streams with static_schema_flag set


Testing Methodology

  1. Start parseable.
  2. Create new static schema stream with an int field.
  3. Push data on the static schema stream with float value.

Without the fix, value is being rounded out, which is wrong as we lose data.

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@coveralls
Copy link

coveralls commented Jan 20, 2025

Pull Request Test Coverage Report for Build 12874465279

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 12.7%

Totals Coverage Status
Change from base Build 12873819985: -0.01%
Covered Lines: 2456
Relevant Lines: 19338

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants