Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: build for all release targets to ensure PRs are compatible #1112

Merged
merged 6 commits into from
Jan 17, 2025

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Jan 17, 2025

Fixes #XXXX.

Description

This changes ensures that we run a CI job to check compatibility of the PR against release targets and ensure we don't fail to compile for a particular target at release.


This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@coveralls
Copy link

coveralls commented Jan 17, 2025

Pull Request Test Coverage Report for Build 12834294538

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 12.715%

Totals Coverage Status
Change from base Build 12832824805: 0.0%
Covered Lines: 2459
Relevant Lines: 19340

💛 - Coveralls

.github/workflows/build.yaml Outdated Show resolved Hide resolved
@de-sh de-sh requested a review from nitisht January 17, 2025 17:57
@nitisht nitisht merged commit 0eba4e2 into parseablehq:main Jan 17, 2025
11 checks passed
@de-sh de-sh deleted the pr-build-verification branch January 17, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants