Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Correlations #1115

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

refactor: Correlations #1115

wants to merge 12 commits into from

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Jan 17, 2025

Fixes #XXXX.

Description

  • Use Deref, enables changing self.0 ~> self.
  • Use HashMap to enable quick retreival.
  • Encapsulate mutations into a single method.

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@coveralls
Copy link

coveralls commented Jan 17, 2025

Pull Request Test Coverage Report for Build 12851512851

Details

  • 0 of 102 (0.0%) changed or added relevant lines in 2 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.01%) to 12.726%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/handlers/http/correlation.rs 0 27 0.0%
src/correlation.rs 0 75 0.0%
Files with Coverage Reduction New Missed Lines %
src/handlers/http/correlation.rs 3 0.0%
src/correlation.rs 4 0.0%
Totals Coverage Status
Change from base Build 12850824320: 0.01%
Covered Lines: 2459
Relevant Lines: 19323

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants