Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: serde privileges #1120

Closed
wants to merge 1 commit into from
Closed

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Jan 19, 2025

Fixes #XXXX.

Description

This is a draft to figure out why the ingestion PR was failing and to discuss what needs to be fixed


This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12855391180

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 15 (0.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 12.713%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/handlers/http/cluster/mod.rs 0 2 0.0%
src/handlers/http/modal/query/querier_role.rs 0 4 0.0%
src/handlers/http/role.rs 0 4 0.0%
src/handlers/http/modal/ingest/ingestor_role.rs 0 5 0.0%
Totals Coverage Status
Change from base Build 12852557722: -0.001%
Covered Lines: 2459
Relevant Lines: 19342

💛 - Coveralls

@de-sh de-sh closed this Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants