Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take another look at the disabled EXCLUDE tests from #1702 #1705

Open
alancai98 opened this issue Jan 9, 2025 · 0 comments
Open

Take another look at the disabled EXCLUDE tests from #1702 #1705

alancai98 opened this issue Jan 9, 2025 · 0 comments
Labels
bug Something isn't working V1 This is related to the V1 release of PartiQL.

Comments

@alancai98
Copy link
Member

PR #1702 cherry-picked #1586 on to the v1 changes. This caused a couple prior tests to fail in PlanTyperTestsPorted.kt -- https://github.com/partiql/partiql-lang-kotlin/pull/1702/files#r1909553749. We should take another look at either

  • changing the behavior or
  • changing the tests to follow the table lookup logic changes
@alancai98 alancai98 added bug Something isn't working V1 This is related to the V1 release of PartiQL. labels Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working V1 This is related to the V1 release of PartiQL.
Projects
None yet
Development

No branches or pull requests

1 participant