Ports v0.14.9 changes #1702
Open
Ports v0.14.9 changes #1702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnedquinn
force-pushed
the
main-pick-prev-changes
branch
from
7fa8526 to
713259f
Compare
alancai98
reviewed
Jan 9, 2025
Comment on lines
+1136
to
+1145
| <<<<<<< HEAD | ||
| [Unreleased]: https://github.com/partiql/partiql-lang-kotlin/compare/v1.0.0-rc.3...HEAD | ||
| [1.0.0-rc.3]: https://github.com/partiql/partiql-lang-kotlin/compare/v1.0.0-rc.2...v1.0.0-rc.3 | ||
| [1.0.0-rc.2]: https://github.com/partiql/partiql-lang-kotlin/compare/v1.0.0-rc.1...v1.0.0-rc.2 | ||
| [1.0.0-rc.1]: https://github.com/partiql/partiql-lang-kotlin/compare/v1.0.0-perf.1...v1.0.0-rc.1 | ||
| [0.14.9]: https://github.com/partiql/partiql-lang-kotlin/compare/v0.14.8...v0.14.9 | ||
| ======= | ||
| [Unreleased]: https://github.com/partiql/partiql-lang-kotlin/compare/v0.14.9...HEAD | ||
| [0.14.8]: https://github.com/partiql/partiql-lang-kotlin/compare/v0.14.8...v0.14.9 | ||
| >>>>>>> 8634620e2 ([0.14.9-SNAPSHOT] Adds warnings for `EXCLUDE` paths that don't exclude any value (#1586)) |
There was a problem hiding this comment.
Probably we can leave out the CHANGELOG changes from the cherry-pick?
Comment on lines
+3744
to
+3757
| @Test | ||
| @Disabled("In August 2024, the table lookup logic changed. This resolves using the current namespace, causing this to fail. This should be looked at. See https://github.com/partiql/partiql-lang-kotlin/commit/7aeb1bea0ee2599cc4a95c6d6fa067e4a7c0028c#diff-b5c8e5a6d813b88ee2a4d21451f116aa90d57bb04330ea7a36813474eafefb66") | ||
| fun excludeWithShadowedGlobalName() { | ||
| val tc = SuccessTestCase( | ||
| name = "EXCLUDE with an open struct - no warning or error", | ||
| catalog = CATALOG_B, | ||
| key = key("exclude-39"), | ||
| expected = PType.bag(PType.dynamic()) | ||
| ) | ||
| runTest(tc) | ||
| } | ||
|
|
||
| @Test | ||
| @Disabled("In August 2024, the table lookup logic changed. This resolves using the current namespace, causing this to fail. This should be looked at. See https://github.com/partiql/partiql-lang-kotlin/commit/7aeb1bea0ee2599cc4a95c6d6fa067e4a7c0028c#diff-b5c8e5a6d813b88ee2a4d21451f116aa90d57bb04330ea7a36813474eafefb66.") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issues
EXCLUDEpaths that don't exclude any value #1586main#1673Description
EXCLUDEpaths that don't exclude any value #1586 tomainfromv0.14.9, converts the use of StaticType to PType, and rebases.License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.