chore(ci): bump setup-arduino-ci version to remove nodejs warning

[pfeerick]

Gets rid of the numerous

"The following actions uses Node.js version which is deprecated and will be forced to run on node20"

warnings which are present in the action summary. And while it is still quite some time away, Github will be ceasing support for NodeJS 16 actions by Spring 2024.

[pfeerick]

I'm not sure if there is need or desire to do so, but it also looks like the arduino-cli version can be bumped from 0.32.2 to 1.0.2 (1.0.0 was released a month ago). I have a second branch based on this which includes a version bump for that, which has successfully built also. https://github.com/pfeerick/DIY-Multiprotocol-TX-Module/tree/pfeerick/ci-bump-arduino-cli-ver

[pascallanger]

Thank you, can you check the code size produced by both versions? If they are identical it is fine with me.

[pfeerick]

Appears to be no difference whatsoever. When I did a file comparison for one file, there was only three bytes difference, so most likely just the timestamp.

edaad73 is current master commit here, 4444ac6 is the action change commit in this PR, 7b5bcb8 is the arduino-cli version bump commit, which I have now cherry-picked into this branch.

File,Size in multi-test-build_edaad73,Size in multi-test-build_4444ac6,Size in multi-test-build_7b5bcb8,Size Difference
mm-stm-5in1-taer-sfc-v1.3.4.11.bin,80228,80228,80228,No
mm-stm-cc2500-64-aetr-lbt-v1.3.4.11.bin,29884,29884,29884,No
mm-tlite5in1-taer-sfc-v1.3.4.11.bin,79408,79408,79408,No
MultiLuaScripts.zip,227146,227146,227146,No
mm-t18int-reta-sfc-v1.3.4.11.bin,79344,79344,79344,No
mm-stm-5in1-reta-air-v1.3.4.11.bin,117600,117600,117600,No
mm-stm-cc2500-taer-lbt-v1.3.4.11.bin,30440,30440,30440,No
mm-avr-txflash-aetr-CYRF6936-inv-v1.3.4.11.bin,30704,30704,30704,No
mm-stm-cc2500-64-taer-v1.3.4.11.bin,53156,53156,53156,No
mm-stm-ppm-aetr-v1.3.4.11.bin,116512,116512,116512,No
mm-stm-5in1-reta-sfc-v1.3.4.11.bin,80228,80228,80228,No
mm-stm-serial-taer-lbt-v1.3.4.11.bin,43116,43116,43116,No
mm-tlite5in1-taer-lbt-v1.3.4.11.bin,42248,42248,42248,No
mm-t18int-taer-air-v1.3.4.11.bin,118564,118564,118564,No
mm-stm-cc2500-aetr-v1.3.4.11.bin,55892,55892,55892,No
mm-stm-cc2500-64-reta-lbt-v1.3.4.11.bin,29884,29884,29884,No
mm-tlite5in1-aetr-sfc-v1.3.4.11.bin,79408,79408,79408,No
mm-stm-serial-reta-sfc-v1.3.4.11.bin,78416,78416,78416,No
mm-stm-5in1-aetr-lbt-v1.3.4.11.bin,43116,43116,43116,No
mm-t18int-reta-lbt-v1.3.4.11.bin,42248,42248,42248,No
mm-stm-serial-taer-sfc-v1.3.4.11.bin,78416,78416,78416,No
mm-stm-xn297dump-usbdebug-v1.3.4.11.bin,58468,58468,58468,No
mm-stm-5in1-aetr-air-v1.3.4.11.bin,117600,117600,117600,No
mm-stm-cc2500-reta-lbt-v1.3.4.11.bin,30440,30440,30440,No
Multi.txt,2289,2289,2289,No
mm-t18int-aetr-sfc-v1.3.4.11.bin,79344,79344,79344,No
mm-tlite5in1-reta-sfc-v1.3.4.11.bin,79408,79408,79408,No
mm-stm-serial-aetr-air-v1.3.4.11.bin,117648,117648,117648,No
mm-t18int-taer-sfc-v1.3.4.11.bin,79344,79344,79344,No
mm-stm-cc2500-reta-v1.3.4.11.bin,55892,55892,55892,No
mm-orangerx-aetr-blue-inv-v1.3.4.11.bin,31108,31108,31108,No
mm-stm-5in1-reta-lbt-v1.3.4.11.bin,43116,43116,43116,No
mm-orangerx-aetr-green-inv-v1.3.4.11.bin,31108,31108,31108,No
mm-tlite5in1-reta-lbt-v1.3.4.11.bin,42248,42248,42248,No
mm-stm-serial-reta-air-v1.3.4.11.bin,117632,117632,117632,No
mm-tlite5in1-aetr-air-v1.3.4.11.bin,118628,118628,118628,No
mm-stm-5in1-taer-lbt-v1.3.4.11.bin,43116,43116,43116,No
mm-stm-serial-aetr-lbt-v1.3.4.11.bin,43116,43116,43116,No
mm-stm-serial-taer-air-v1.3.4.11.bin,117648,117648,117648,No
mm-avr-usbasp-aetr-CYRF6936-inv-v1.3.4.11.bin,30492,30492,30492,No
mm-tlite5in1-reta-air-v1.3.4.11.bin,118612,118612,118612,No
mm-stm-5in1-aetr-sfc-v1.3.4.11.bin,80228,80228,80228,No
mm-stm-cc2500-64-taer-lbt-v1.3.4.11.bin,29884,29884,29884,No
mm-t18int-taer-lbt-v1.3.4.11.bin,42248,42248,42248,No
mm-stm-5in1-taer-air-v1.3.4.11.bin,117616,117616,117616,No
mm-stm-serial-aetr-sfc-v1.3.4.11.bin,78416,78416,78416,No
mm-stm-serial-reta-lbt-v1.3.4.11.bin,43116,43116,43116,No
mm-tlite5in1-aetr-lbt-v1.3.4.11.bin,42248,42248,42248,No
mm-stm-cc2500-64-reta-v1.3.4.11.bin,53156,53156,53156,No
mm-stm-ppm-reta-v1.3.4.11.bin,116512,116512,116512,No
mm-stm-xn297dump-ftdidebug-v1.3.4.11.bin,52852,52852,52852,No
mm-stm-cc2500-aetr-lbt-v1.3.4.11.bin,30440,30440,30440,No
mm-avr-usbasp-aetr-CC2500-inv-v1.3.4.11.bin,31500,31500,31500,No
mm-stm-cc2500-64-aetr-v1.3.4.11.bin,53156,53156,53156,No
mm-avr-txflash-aetr-A7105-inv-v1.3.4.11.bin,25582,25582,25582,No
mm-t18int-aetr-air-v1.3.4.11.bin,118564,118564,118564,No
mm-tlite5in1-taer-air-v1.3.4.11.bin,118628,118628,118628,No
mm-t18int-reta-air-v1.3.4.11.bin,118548,118548,118548,No
mm-avr-txflash-aetr-CC2500-inv-v1.3.4.11.bin,31714,31714,31714,No
mm-stm-cc2500-taer-v1.3.4.11.bin,55892,55892,55892,No
mm-avr-usbasp-aetr-A7105-inv-v1.3.4.11.bin,25364,25364,25364,No
mm-t18int-aetr-lbt-v1.3.4.11.bin,42248,42248,42248,No
mm-stm-ppm-taer-v1.3.4.11.bin,116528,116528,116528,No

[pascallanger]

@pfeerick The automatic build is currently broken which is due to the bump of the arduino version. It looks like the signature is missing from the bin files and therefore refused by the radio.
@benlye is there a way to fix it or should we revert the change?

[benlye]

We would have to release a new board package to fix this.

The problem is that the build recipe runs a script which scans the intermediary files, checking firmware options to determine what the signature should be. It looks like that intermediary file is no longer where the script expects it to be.

This is the problem:

grep: /home/runner/work/DIY-Multiprotocol-TX-Module/DIY-Multiprotocol-TX-Module/build/preproc/ctags_target_for_gcc_minus_e.cpp: No such file or directory
grep: /home/runner/work/DIY-Multiprotocol-TX-Module/DIY-Multiprotocol-TX-Module/build/preproc/ctags_target_for_gcc_minus_e.cpp: No such file or directory
grep: /home/runner/work/DIY-Multiprotocol-TX-Module/DIY-Multiprotocol-TX-Module/build/preproc/ctags_target_for_gcc_minus_e.cpp: No such file or directory
grep: /home/runner/work/DIY-Multiprotocol-TX-Module/DIY-Multiprotocol-TX-Module/build/preproc/ctags_target_for_gcc_minus_e.cpp: No such file or directory
grep: /home/runner/work/DIY-Multiprotocol-TX-Module/DIY-Multiprotocol-TX-Module/build/preproc/ctags_target_for_gcc_minus_e.cpp: No such file or directory

And this is why:
https://github.com/pascallanger/DIY-Multiprotocol-TX-Module-Boards/blob/b75740530f1b8b91dc03879c15f706352541fc98/source/avr/tools/linux/do_version#L90

I'm not in a position where I can do a new boards package or a few weeks, so it might be best to revert this until we can get that done.

[benlye]

It looks like I should also see if I can get arduino-cli to return an error if that script fails (I'm fairly sure we've seen something like this happen before).

[pfeerick]

I'm not in a position to look at this for a few days either, so I'm good with reverting for now also.