Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/use offer categorization api model #211

Merged
merged 7 commits into from
Oct 2, 2024

Conversation

lmontier-pass
Copy link
Contributor

Generic PR

Describe your changes

Please include a summary of the changes:

This PR [adds/removes/fixes/replaces] the [feature/bug/etc].

Tag a reviewer if necessacy @github/username

Jira ticket number and/or notion link

JIRA-ticket_number

Which API ?

  • API reco
  • API papillon

Type of change

  • New model
  • New endpoint
  • New route
  • Deletion -> what ?:
  • Code Refacto and performance Improvements
  • Testing
  • CI
  • Config

Checklist before requesting a review

  • I have performed a self-review of my code
  • My code passes CI/CD tests
  • I updated README.md
  • My PR contains only a single commit (squash them if needed)
  • I will create a review on slack and ensure to specify the duration of the review task: short (<10min), medium (<30min), long (>30min)

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • ⏰ no, but I created a ticket

@lmontier-pass lmontier-pass force-pushed the feat/use-offer-categorization-api-model branch from 62ae50d to df25804 Compare October 1, 2024 14:06
@lmontier-pass lmontier-pass merged commit 14162e3 into main Oct 2, 2024
3 checks passed
@lmontier-pass lmontier-pass deleted the feat/use-offer-categorization-api-model branch October 2, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant