From 685150e8f41207ed21431b8eb8fa87b67df83926 Mon Sep 17 00:00:00 2001 From: cdelabre Date: Fri, 30 Aug 2024 18:54:39 +0200 Subject: [PATCH 1/2] =?UTF-8?q?[HOTIFX]=C2=A0fix:=20default=20var=20with?= =?UTF-8?q?=20cast?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- apps/recommendation/api/src/huggy/utils/env_vars.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/apps/recommendation/api/src/huggy/utils/env_vars.py b/apps/recommendation/api/src/huggy/utils/env_vars.py index be9f29a5..f40f88e8 100644 --- a/apps/recommendation/api/src/huggy/utils/env_vars.py +++ b/apps/recommendation/api/src/huggy/utils/env_vars.py @@ -56,7 +56,9 @@ "RANKING_VERSION_B_ENDPOINT_NAME", f"recommendation_user_ranking_version_b_{ENV_SHORT_NAME}", ) -NUMBER_OF_RECOMMENDATIONS = os.environ.get( - "NUMBER_OF_RECOMMENDATIONS", - 40, +NUMBER_OF_RECOMMENDATIONS = int( + os.environ.get( + "NUMBER_OF_RECOMMENDATIONS", + 40, + ) ) From 729fa61fe4d40efb7f154d4d9ba49cf5ecc0e510 Mon Sep 17 00:00:00 2001 From: cdelabre Date: Thu, 5 Sep 2024 18:42:43 +0200 Subject: [PATCH 2/2] feat: keep 60 offers per default --- apps/recommendation/api/src/huggy/core/endpoint/__init__.py | 2 +- apps/recommendation/api/src/huggy/core/scorer/offer.py | 2 +- apps/recommendation/api/src/huggy/utils/env_vars.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/apps/recommendation/api/src/huggy/core/endpoint/__init__.py b/apps/recommendation/api/src/huggy/core/endpoint/__init__.py index 46117131..1e8a6f16 100644 --- a/apps/recommendation/api/src/huggy/core/endpoint/__init__.py +++ b/apps/recommendation/api/src/huggy/core/endpoint/__init__.py @@ -6,7 +6,7 @@ from huggy.utils.hash import hash_from_keys VERTEX_CACHE = Cache( - Cache.MEMORY, ttl=6000, serializer=PickleSerializer(), namespace="vertex_cache" + Cache.MEMORY, ttl=3000, serializer=PickleSerializer(), namespace="vertex_cache" ) diff --git a/apps/recommendation/api/src/huggy/core/scorer/offer.py b/apps/recommendation/api/src/huggy/core/scorer/offer.py index 6734cd89..168cd912 100644 --- a/apps/recommendation/api/src/huggy/core/scorer/offer.py +++ b/apps/recommendation/api/src/huggy/core/scorer/offer.py @@ -22,7 +22,7 @@ from sqlalchemy.ext.asyncio import AsyncSession OFFER_DB_CACHE = Cache( - Cache.MEMORY, ttl=6000, serializer=PickleSerializer(), namespace="offer_db_cache" + Cache.MEMORY, ttl=3000, serializer=PickleSerializer(), namespace="offer_db_cache" ) diff --git a/apps/recommendation/api/src/huggy/utils/env_vars.py b/apps/recommendation/api/src/huggy/utils/env_vars.py index f40f88e8..8b5249ac 100644 --- a/apps/recommendation/api/src/huggy/utils/env_vars.py +++ b/apps/recommendation/api/src/huggy/utils/env_vars.py @@ -59,6 +59,6 @@ NUMBER_OF_RECOMMENDATIONS = int( os.environ.get( "NUMBER_OF_RECOMMENDATIONS", - 40, + 60, ) )