(PC-33608) refactor(LocationLabel): use Enum

__snapshots__/features/location/components/HomeLocationModal.native.test.tsx.native-snap

@@ -711,7 +711,7 @@ exports[`HomeLocationModal should render correctly if modal visible 1`] = `
                       ]
                     }
                   >
-                    France entière
+                    France Entière
                   </Text>
                 </View>
               </View>

__snapshots__/features/location/components/SearchLocationModal.native.test.tsx.native-snap

@@ -712,7 +712,7 @@ exports[`SearchLocationModal should render correctly if modal visible 1`] = `
                       ]
                     }
                   >
-                    France entière
+                    France Entière
                   </Text>
                 </View>
               </View>

__snapshots__/features/search/pages/ThematicSearch/ThematicSearch.native.test.tsx.native-snap

@@ -468,7 +468,7 @@ exports[`<ThematicSearch/> book offerCategory should render <ThematicSearch /> 1
                         ]
                       }
                     >
-                      Me localiser
+                      France Entière
                     </Text>
                   </View>
                   <Modal

src/features/home/components/headers/HomeHeader.native.test.tsx

@@ -12,6 +12,7 @@ import {
 import * as Auth from 'features/auth/context/AuthContext'
 import { nonBeneficiaryUser } from 'fixtures/user'
 import * as useFeatureFlagAPI from 'libs/firebase/firestore/featureFlags/useFeatureFlag'
+import { LocationLabel } from 'libs/location/types'
 import { Credit, useAvailableCredit } from 'shared/user/useAvailableCredit'
 import { mockServer } from 'tests/mswServer'
 import { reactQueryProviderHOC } from 'tests/reactQueryProviderHOC'
@@ -96,7 +97,7 @@ describe('HomeHeader', () => {
 
     await screen.findByTestId('Ouvrir la modale de localisation depuis le widget')
 
-    expect(screen.getByText('France entière')).toBeTruthy()
+    expect(screen.getByText(LocationLabel.everywhereLabel)).toBeTruthy()
   })
 
   it('should not show LocationWidget isDesktopViewport is true', async () => {

src/features/internal/marketingAndCommunication/atoms/LocationFilterChoice.native.test.tsx

@@ -1,15 +1,15 @@
 import React from 'react'
 
 import { LocationFilterChoice } from 'features/internal/marketingAndCommunication/atoms/LocationFilterChoice'
-import { LocationMode } from 'libs/location/types'
+import { LocationLabel, LocationMode } from 'libs/location/types'
 import { render, fireEvent, screen } from 'tests/utils'
 
 describe('<LocationFilterChoice />', () => {
   it('should call onChange with LocationMode.AROUND_ME or EVERYWHERE', () => {
     const onChange = jest.fn()
     render(<LocationFilterChoice onChange={onChange} />)
 
-    fireEvent.press(screen.getByText('France entière'))
+    fireEvent.press(screen.getByText(LocationLabel.everywhereLabel))
 
     expect(onChange).toHaveBeenNthCalledWith(1, {
       locationType: LocationMode.EVERYWHERE,

src/features/internal/marketingAndCommunication/atoms/LocationFilterChoice.tsx

@@ -2,7 +2,7 @@ import React, { useCallback, useState } from 'react'
 
 import { LocationChoice } from 'features/search/components/LocationChoice'
 import { LocationFilter } from 'features/search/types'
-import { LocationMode } from 'libs/location/types'
+import { LocationLabel, LocationMode } from 'libs/location/types'
 import { Li } from 'ui/components/Li'
 import { VerticalUl } from 'ui/components/Ul'
 import { BicolorEverywhere as Everywhere } from 'ui/svg/icons/BicolorEverywhere'
@@ -25,7 +25,7 @@ export const LocationFilterChoice = ({ onChange }: Props) => {
       <Li>
         <Spacer.Column numberOfSpaces={4} />
         <LocationChoice
-          label="France entière"
+          label={LocationLabel.everywhereLabel}
           Icon={Everywhere}
           onPress={onPressEverywhere}
           isSelected={LocationMode.EVERYWHERE === selected}

src/features/location/components/LocationModal.tsx

@@ -6,7 +6,7 @@ import { LocationModalFooter } from 'features/location/components/LocationModalF
 import { LOCATION_PLACEHOLDER } from 'features/location/constants'
 import { LocationState } from 'features/location/types'
 import { Action } from 'features/search/context/reducer'
-import { LocationMode } from 'libs/location/types'
+import { LocationLabel, LocationMode } from 'libs/location/types'
 import { SuggestedPlace } from 'libs/place/types'
 import { LocationSearchFilters } from 'shared/location/LocationSearchFilters'
 import { LocationSearchInput } from 'shared/location/LocationSearchInput'
@@ -168,7 +168,7 @@ export const LocationModal = ({
           onPress={selectLocationMode(LocationMode.EVERYWHERE)}
           icon={WorldPosition}
           color={everywhereLocationModeColor}
-          title="France entière"
+          title={LocationLabel.everywhereLabel}
         />
       </StyledScrollView>
     </AppModal>

src/features/location/components/LocationSearchWidget.native.test.tsx

@@ -3,7 +3,7 @@ import React from 'react'
 
 import { LocationSearchWidget } from 'features/location/components/LocationSearchWidget'
 import { useLocation } from 'libs/location'
-import { LocationMode } from 'libs/location/types'
+import { LocationLabel, LocationMode } from 'libs/location/types'
 import { act, fireEvent, render, screen } from 'tests/utils'
 
 const mockShowModal = jest.fn()
@@ -44,7 +44,7 @@ describe('LocationSearchWidget', () => {
     ${true}           | ${null}
     ${true}           | ${undefined}
   `(
-    "should render a filled location pointer and the text 'Ma position' if the user is geolocated",
+    `should render a filled location pointer and the text ${LocationLabel.aroundMeLabel} if the user is geolocated`,
     async ({ hasGeolocPosition, place }) => {
       mockUseLocation.mockReturnValueOnce({
         hasGeolocPosition,
@@ -55,7 +55,7 @@ describe('LocationSearchWidget', () => {
       render(<LocationSearchWidget />)
 
       expect(screen.getByTestId('location pointer filled')).toBeOnTheScreen()
-      expect(screen.getByText('Ma position')).toBeOnTheScreen()
+      expect(screen.getByText(LocationLabel.aroundMeLabel)).toBeOnTheScreen()
     }
   )
 
@@ -64,7 +64,7 @@ describe('LocationSearchWidget', () => {
     ${false}          | ${null}
     ${false}          | ${undefined}
   `(
-    "should render a location pointer(not filled ) and the text 'France entière' if the user is not geolocated and has not selected a custom position",
+    `should render a location pointer(not filled ) and the text ${LocationLabel.everywhereLabel} if the user is not geolocated and has not selected a custom position`,
     async ({ hasGeolocPosition, place }) => {
       mockUseLocation.mockReturnValueOnce({
         hasGeolocPosition,
@@ -76,7 +76,7 @@ describe('LocationSearchWidget', () => {
       render(<LocationSearchWidget />)
 
       expect(screen.getByTestId('location pointer not filled')).toBeOnTheScreen()
-      expect(screen.getByText('France entière')).toBeOnTheScreen()
+      expect(screen.getByText(LocationLabel.everywhereLabel)).toBeOnTheScreen()
     }
   )
 

src/features/location/components/LocationWidgetDesktop.native.test.tsx

@@ -4,7 +4,7 @@ import React from 'react'
 import { LocationWidgetDesktop } from 'features/location/components/LocationWidgetDesktop'
 import * as useFeatureFlag from 'libs/firebase/firestore/featureFlags/useFeatureFlag'
 import { useLocation } from 'libs/location'
-import { LocationMode } from 'libs/location/types'
+import { LocationLabel, LocationMode } from 'libs/location/types'
 import { storage } from 'libs/storage'
 import { act, fireEvent, render, screen } from 'tests/utils'
 
@@ -46,7 +46,7 @@ describe('LocationWidgetDesktop', () => {
     ${true}           | ${null}
     ${true}           | ${undefined}
   `(
-    "should render a filled location pointer and the text 'Ma position' if the user is geolocated",
+    `should render a filled location pointer and the text ${LocationLabel.aroundMeLabel} if the user is geolocated`,
     async ({ hasGeolocPosition, place }) => {
       mockUseLocation.mockReturnValueOnce({
         hasGeolocPosition,
@@ -58,7 +58,7 @@ describe('LocationWidgetDesktop', () => {
       renderLocationWidgetDesktop()
 
       expect(screen.getByTestId('location pointer filled')).toBeOnTheScreen()
-      expect(screen.getByText('Ma position')).toBeOnTheScreen()
+      expect(screen.getByText(LocationLabel.aroundMeLabel)).toBeOnTheScreen()
     }
   )
 
@@ -67,7 +67,7 @@ describe('LocationWidgetDesktop', () => {
     ${false}          | ${null}
     ${false}          | ${undefined}
   `(
-    "should render a location pointer(not filled ) and the text 'France entière' if the user is not geolocated and has not selected a custom position",
+    'should render a location pointer(not filled ) and the text LocationLabel.everywhereLabel if the user is not geolocated and has not selected a custom position',
     async ({ hasGeolocPosition, place }) => {
       mockUseLocation.mockReturnValueOnce({
         hasGeolocPosition,
@@ -80,7 +80,7 @@ describe('LocationWidgetDesktop', () => {
       renderLocationWidgetDesktop()
 
       expect(screen.getByTestId('location pointer not filled')).toBeOnTheScreen()
-      expect(screen.getByText('France entière')).toBeOnTheScreen()
+      expect(screen.getByText(LocationLabel.everywhereLabel)).toBeOnTheScreen()
     }
   )
 
@@ -167,7 +167,7 @@ describe('LocationWidgetDesktop', () => {
       ).not.toBeOnTheScreen()
     })
 
-    it('should hide tooltip when taping “France entière”', async () => {
+    it(`should hide tooltip when taping ${LocationLabel.everywhereLabel}`, async () => {
       jest.useFakeTimers()
       renderLocationWidgetDesktop()
 
@@ -179,7 +179,7 @@ describe('LocationWidgetDesktop', () => {
         'Configure ta position et découvre les offres dans la zone géographique de ton choix.'
       )
 
-      const locationButton = screen.getByText('France entière')
+      const locationButton = screen.getByText(LocationLabel.everywhereLabel)
       fireEvent.press(locationButton)
 
       expect(

src/features/location/helpers/getLocationTitle.ts

@@ -1,16 +1,16 @@
-import { LocationMode } from 'libs/location/types'
+import { LocationLabel, LocationMode } from 'libs/location/types'
 import { SuggestedPlace } from 'libs/place/types'
 
 export const getLocationTitle = (place: SuggestedPlace | null, locationMode: LocationMode) => {
   switch (locationMode) {
     case LocationMode.AROUND_PLACE:
       return place?.label ?? ''
     case LocationMode.EVERYWHERE:
-      return 'France entière'
+      return LocationLabel.everywhereLabel
     case LocationMode.AROUND_ME:
-      return 'Ma position'
+      return LocationLabel.aroundMeLabel
 
     default:
-      return 'France entière'
+      return LocationLabel.everywhereLabel
   }
 }

src/features/search/components/SearchBox/SearchBox.native.test.tsx

@@ -10,7 +10,7 @@ import * as useFilterCountAPI from 'features/search/helpers/useFilterCount/useFi
 import { BooksNativeCategoriesEnum, SearchState, SearchView } from 'features/search/types'
 import * as useFeatureFlagAPI from 'libs/firebase/firestore/featureFlags/useFeatureFlag'
 import { GeoCoordinates, Position } from 'libs/location'
-import { LocationMode } from 'libs/location/types'
+import { LocationLabel, LocationMode } from 'libs/location/types'
 import { mockedSuggestedVenue } from 'libs/venue/fixtures/mockedSuggestedVenues'
 import { act, fireEvent, render, screen } from 'tests/utils'
 
@@ -553,7 +553,7 @@ describe('SearchBox component', () => {
 
     await act(async () => {})
 
-    expect(screen.getByText('France entière')).toBeOnTheScreen()
+    expect(screen.getByText(LocationLabel.everywhereLabel)).toBeOnTheScreen()
   })
 })
 

src/features/search/components/SearchHeader/SearchHeader.native.test.tsx

@@ -5,6 +5,7 @@ import { SearchHeader } from 'features/search/components/SearchHeader/SearchHead
 import { initialSearchState } from 'features/search/context/reducer'
 import * as useFilterCountAPI from 'features/search/helpers/useFilterCount/useFilterCount'
 import * as useFeatureFlag from 'libs/firebase/firestore/featureFlags/useFeatureFlag'
+import { LocationLabel } from 'libs/location/types'
 import { render, screen, waitFor, within } from 'tests/utils'
 
 jest.spyOn(useFeatureFlag, 'useFeatureFlag').mockReturnValue(false)
@@ -68,7 +69,7 @@ describe('SearchHeader component', () => {
     await waitFor(() => {
       const insideLocationWidget = within(screen.getByTestId('InsideLocationWidget'))
 
-      expect(insideLocationWidget.getByText('France entière')).toBeOnTheScreen()
+      expect(insideLocationWidget.getByText(LocationLabel.everywhereLabel)).toBeOnTheScreen()
     })
   })
 
@@ -78,7 +79,7 @@ describe('SearchHeader component', () => {
     await waitFor(() => {
       const insideLocationWidget = within(screen.getByTestId('InsideLocationWidget'))
 
-      expect(insideLocationWidget.queryByText('France entière')).not.toBeOnTheScreen()
+      expect(insideLocationWidget.queryByText(LocationLabel.everywhereLabel)).not.toBeOnTheScreen()
     })
   })
 
@@ -88,7 +89,9 @@ describe('SearchHeader component', () => {
     await waitFor(() => {
       const searchHeaderTitleContainer = within(screen.getByTestId('SearchHeaderTitleContainer'))
 
-      expect(searchHeaderTitleContainer.queryByText('France entière')).not.toBeOnTheScreen()
+      expect(
+        searchHeaderTitleContainer.queryByText(LocationLabel.everywhereLabel)
+      ).not.toBeOnTheScreen()
     })
   })
 
@@ -98,7 +101,7 @@ describe('SearchHeader component', () => {
     await waitFor(() => {
       const insideLocationWidget = within(screen.getByTestId('InsideLocationWidget'))
 
-      expect(insideLocationWidget.queryByText('France entière')).not.toBeOnTheScreen()
+      expect(insideLocationWidget.queryByText(LocationLabel.everywhereLabel)).not.toBeOnTheScreen()
     })
   })
 
@@ -108,7 +111,7 @@ describe('SearchHeader component', () => {
     await waitFor(() => {
       const searchHeaderTitleContainer = within(screen.getByTestId('SearchHeaderTitleContainer'))
 
-      expect(searchHeaderTitleContainer.getByText('France entière')).toBeOnTheScreen()
+      expect(searchHeaderTitleContainer.getByText(LocationLabel.everywhereLabel)).toBeOnTheScreen()
     })
   })
 })

src/features/search/context/SearchWrapper.native.test.tsx

@@ -9,7 +9,7 @@ import {
   useLocation,
 } from 'libs/location'
 import { getGeolocPosition } from 'libs/location/geolocation/getGeolocPosition/getGeolocPosition'
-import { LocationMode } from 'libs/location/types'
+import { LocationLabel, LocationMode } from 'libs/location/types'
 import { SuggestedPlace } from 'libs/place/types'
 import { act, fireEvent, render, screen } from 'tests/utils'
 
@@ -61,7 +61,7 @@ describe('SearchWrapper', () => {
     expect(screen.getByText(LocationMode.AROUND_ME)).toBeOnTheScreen()
   })
 
-  it('should update locationType with type Everywhere when Location Context is switched to "France Entière"', async () => {
+  it(`should update locationType with type Everywhere when Location Context is switched to ${LocationLabel.everywhereLabel}`, async () => {
     renderDummyComponent()
 
     await act(async () => {

src/libs/location/types.ts

@@ -10,6 +10,11 @@ export enum LocationMode {
   EVERYWHERE = 'EVERYWHERE',
 }
 
+export const enum LocationLabel {
+  everywhereLabel = 'France Entière',
+  aroundMeLabel = 'Ma position',
+}
+
 export type GeolocationError = {
   type: GeolocPositionError
   message: string