Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PC-32322) chore(api): update schema api #7056

Merged
merged 3 commits into from
Oct 18, 2024
Merged

(PC-32322) chore(api): update schema api #7056

merged 3 commits into from
Oct 18, 2024

Conversation

Lucasbeneston
Copy link
Contributor

@Lucasbeneston Lucasbeneston commented Oct 18, 2024

Link to JIRA ticket: https://passculture.atlassian.net/browse/PC-32322

Flakiness

If I had to re-run tests in the CI due to flakiness, I add the incident [on Notion][2]

Checklist

I have:

  • Made sure my feature is working on web.
  • Made sure my feature is working on mobile (depending on relevance : real or virtual devices)
  • Written unit tests native (and web when implementation is different) for my feature.
  • Added a screenshot for UI tickets or deleted the screenshot section if no UI change
  • If my PR is a bugfix, I add the link of the "résolution de problème sur le bug" [on Notion][1]

Copy link

sonarcloud bot commented Oct 18, 2024

Copy link

Performance Comparison Report

Significant Changes To Render Duration

There are no entries

Meaningless Changes To Render Duration

Show entries
Name Render Duration Render Count
Performance test for Bookings page 93.8 ms → 96.2 ms (+2.4 ms, +2.6%) 11 → 11
Performance test for Favorites page 65.1 ms → 66.2 ms (+1.1 ms, +1.7%) 6 → 6
Search Landing Page - Performance test for Search Landing page 13.9 ms → 14.8 ms (+0.9 ms, +6.5%) 5 → 5
Performance test for EndedBookings page 30.9 ms → 31.3 ms (+0.4 ms, +1.3%) 6 → 6
Search Results - Performance test for Search Results page 13.9 ms → 14.0 ms (+0.1 ms, +0.7%) 5 → 5
Performance test for Venue page 2.8 ms → 2.8 ms 2 → 2
Performance test for Profile page 6.5 ms → 6.0 ms (-0.5 ms, -7.7%) 5 → 5
Performance test for Offer page 71.6 ms → 71.0 ms (-0.6 ms, -0.8%) 2 → 2
Show details
Name Render Duration Render Count
Performance test for Bookings page Baseline
Mean: 93.8 ms
Stdev: 2.3 ms (2.5%)
Runs: 99 97 94 93 93 93 93 92 92 92

Current
Mean: 96.2 ms
Stdev: 3.8 ms (3.9%)
Runs: 103 101 97 97 97 96 95 93 92 91
Baseline
Mean: 11
Stdev: 0 (0.0%)
Runs: 11 11 11 11 11 11 11 11 11 11

Current
Mean: 11
Stdev: 0 (0.0%)
Runs: 11 11 11 11 11 11 11 11 11 11
Performance test for Favorites page Baseline
Mean: 65.1 ms
Stdev: 2.2 ms (3.4%)
Runs: 68 67 67 67 66 65 63 63 63 62

Current
Mean: 66.2 ms
Stdev: 1.7 ms (2.5%)
Runs: 70 67 67 67 66 66 65 65 65 64
Baseline
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6

Current
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6
Search Landing Page - Performance test for Search Landing page Baseline
Mean: 13.9 ms
Stdev: 2.2 ms (16.1%)
Runs: 16 16 16 16 14 13 13 13 13 9

Current
Mean: 14.8 ms
Stdev: 2.0 ms (13.4%)
Runs: 17 17 17 16 15 15 14 13 12 12
Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Performance test for EndedBookings page Baseline
Mean: 30.9 ms
Stdev: 1.5 ms (4.9%)
Runs: 33 33 32 32 31 30 30 30 29 29

Current
Mean: 31.3 ms
Stdev: 0.9 ms (3.0%)
Runs: 33 32 32 32 31 31 31 31 30 30
Baseline
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6

Current
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6
Search Results - Performance test for Search Results page Baseline
Mean: 13.9 ms
Stdev: 1.7 ms (12.4%)
Runs: 16 16 15 15 14 14 14 12 12 11

Current
Mean: 14.0 ms
Stdev: 1.6 ms (11.7%)
Runs: 16 16 15 15 14 14 14 13 12 11
Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Performance test for Venue page Baseline
Mean: 2.8 ms
Stdev: 0.6 ms (22.6%)
Runs: 4 3 3 3 3 3 3 2 2 2

Current
Mean: 2.8 ms
Stdev: 0.6 ms (22.6%)
Runs: 4 3 3 3 3 3 3 2 2 2
Baseline
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2

Current
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Performance test for Profile page Baseline
Mean: 6.5 ms
Stdev: 1.0 ms (15.0%)
Runs: 8 8 7 7 6 6 6 6 6 5

Current
Mean: 6.0 ms
Stdev: 1.2 ms (19.2%)
Runs: 8 7 7 6 6 6 6 5 5 4
Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Performance test for Offer page Baseline
Mean: 71.6 ms
Stdev: 3.6 ms (5.0%)
Runs: 76 76 75 73 72 71 71 69 68 65

Current
Mean: 71.0 ms
Stdev: 1.8 ms (2.5%)
Runs: 74 72 72 72 72 71 70 70 69 68
Baseline
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2

Current
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2

Changes To Render Count

There are no entries

Added Scenarios

There are no entries

Removed Scenarios

There are no entries

Generated by 🚫 dangerJS against f5df962

Copy link

sonarcloud bot commented Oct 18, 2024

@Lucasbeneston Lucasbeneston changed the title (PC-32322) feat(api): update schema api (PC-32322) chore(api): update schema api Oct 18, 2024
@Lucasbeneston Lucasbeneston merged commit 29b814d into master Oct 18, 2024
56 checks passed
@Lucasbeneston Lucasbeneston deleted the PC-32322 branch October 18, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants