(PC-32510) chore(pipeline): slack message only on failure or success #7058
+15
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NolwenMajorFrances
force-pushed
the
PC-32510
branch
from
cf5422e
to
1245ab0
Compare
NolwenMajorFrances
force-pushed
the
PC-32510
branch
8 times, most recently
from
167c40d
to
2110516
Compare
bruno-ebstein-pass-culture
approved these changes
Oct 21, 2024
.github/workflows/dev_on_workflow_environment_android_deploy.yml
Outdated
Show resolved
Hide resolved
| @@ -129,13 +129,13 @@ jobs: | |||
| "attachments": [ | |||
| { | |||
| "mrkdwn_in": ["text"], | |||
| "color": "${{ fromJSON('["#A30002","#36a64f"]')[steps.sentry_and_deploy.outputs.status == 'success'] }}", | |||
| "color": "${{ fromJSON('["#36a64f", "#A30002"]')[needs.sentry_and_deploy.result == 'failure'] }}", | |||
There was a problem hiding this comment.
je ne savais pas qu'on avait accès à cette info dans needs
est-ce tu sais pourquoi steps semblait fonctionner la semaine dernière ?
There was a problem hiding this comment.
aucune idée, j'ai juste suivi les préconisations de Matthias !
There was a problem hiding this comment.
réponse de Matthias pour dans quelques mois quand on se posera la question de ces modifications :
pourquoi on peut utiliser needs et pas steps ?
"parce qu'on est pas dans le meme job
la on a deux runners distincts qui ont une relation de co dépendance (le needs))
et c'est grace à cette relation qu'on peut appeler le result du premier job
si on était dans le meme job on aurait pu appeler le result de la step voulu (en lui donnant un petit nom), de mémoire cest ce qui est fait pour le workflow de test "
There was a problem hiding this comment.
je suis code cité, j'aime ça
Performance Comparison ReportSignificant Changes To Render DurationThere are no entries Meaningless Changes To Render DurationShow entries
Show details
Changes To Render CountThere are no entries Added ScenariosThere are no entries Removed ScenariosThere are no entries |
NolwenMajorFrances
force-pushed
the
PC-32510
branch
from
2110516
to
94020c5
Compare
NolwenMajorFrances
force-pushed
the
PC-32510
branch
from
94020c5
to
e181975
Compare
bruno-ebstein-pass-culture
approved these changes
Oct 21, 2024
mlachevre-pass
approved these changes
Oct 21, 2024
|
NolwenMajorFrances
changed the title
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket: https://passculture.atlassian.net/browse/PC-XXXXX
Flakiness
If I had to re-run tests in the CI due to flakiness, I add the incident on Notion
Checklist
I have:
Screenshots
delete if no UI change