Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PC-33308) feat(Home): use releaseDate to display date on cine offers #7296

Merged
merged 6 commits into from
Nov 29, 2024

Conversation

imouandjolobe-pass
Copy link
Contributor

@imouandjolobe-pass imouandjolobe-pass commented Nov 27, 2024

Link to JIRA ticket: https://passculture.atlassian.net/browse/PC-33308

Flakiness

If I had to re-run tests in the CI due to flakiness, I add the incident on Notion

Checklist

I have:

  • Made sure my feature is working on web.
  • Made sure my feature is working on mobile (depending on relevance : real or virtual devices)
  • Written unit tests native (and web when implementation is different) for my feature.
  • Added a screenshot for UI tickets or deleted the screenshot section if no UI change
  • I am aware of all the best practices and respected them.

Screenshots

delete if no UI change

Platform Mockup/After
Desktop - Chrome
Desktop - Chrome Capture d’écran 2024-11-29 à 09 20 00
Desktop - Chrome Capture d’écran 2024-11-29 à 10 14 30

Best Practices

Click to expand
  • Remove non-null assertion operators (just like other type assertions, this doesn’t change the runtime behavior of your code, so it’s important to only use ! when you know that the value can’t be null or undefined).

Test specific:

  • When you see a local variable that is over-written in every test, mock it.
  • Prefer user to fireEvent.

Copy link
Contributor

@xlecunff-pass xlecunff-pass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beau ticket de refacto 🎉

@imouandjolobe-pass imouandjolobe-pass merged commit 4a19556 into master Nov 29, 2024
53 checks passed
@imouandjolobe-pass imouandjolobe-pass deleted the PC-33308 branch November 29, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants