(BSR) fix(venueMap): filters modal presentation #7305
Conversation
mmeissonnier-pass
force-pushed
the
fix/BSR-filters-modal-presentation
branch
2 times, most recently
from
d7fd441 to
83b5058
Compare
|
|
||
| export const VenueMapFiltersStackNavigator = () => { | ||
| useWhiteStatusBar() |
There was a problem hiding this comment.
Pour ma compréhension ça fait quoi ça ?
There was a problem hiding this comment.
C'est un hook qui force la status bar en theme light quand le screen est focus et qui la remet en theme dark quand on sort de ce même screen.
| import { StackNavigationOptions, TransitionPresets, TransitionSpecs } from '@react-navigation/stack' | ||
|
|
||
| export const FILTERS_MODAL_NAV_OPTIONS: StackNavigationOptions = { | ||
| ...TransitionPresets.ModalSlideFromBottomIOS, |
There was a problem hiding this comment.
C'est Ok pour Android aussi ?
There was a problem hiding this comment.
J'ai fait quelques tests de mon côté, ça me paraissait correct. Mais 2 avis valent mieux qu'un 😃
There was a problem hiding this comment.
C'est dans cette partie que tu as réussi à te débarrasser du petit espace iOS ?
There was a problem hiding this comment.
mmeissonnier-pass
force-pushed
the
fix/BSR-filters-modal-presentation
branch
2 times, most recently
from
b96a6dd to
889b1a1
Compare
mmeissonnier-pass
force-pushed
the
fix/BSR-filters-modal-presentation
branch
from
889b1a1 to
97946ad
Compare
|
|
| import { StackNavigationOptions, TransitionPresets, TransitionSpecs } from '@react-navigation/stack' | ||
|
|
||
| export const FILTERS_MODAL_NAV_OPTIONS: StackNavigationOptions = { | ||
| ...TransitionPresets.ModalSlideFromBottomIOS, |
There was a problem hiding this comment.
C'est dans cette partie que tu as réussi à te débarrasser du petit espace iOS ?
| @@ -29,8 +28,6 @@ export const SearchCustomModalHeader: React.FC<Props> = ({ | |||
| shouldDisplayCloseButton, | |||
| onClose, | |||
| }) => { | |||
| useWhiteStatusBar() | |||
There was a problem hiding this comment.
Le fait que tu retires l'utilisation du hook ici n'a pas d'impact sur la recherche ?
Pour faire en sorte de faire apparaitre la modale react-navigation comme les autres modales react-native
Flakiness
If I had to re-run tests in the CI due to flakiness, I add the incident on Notion
Checklist
I have:
Screenshots
Android
Kapture.2024-11-29.at.09.40.26.mp4
iOS
Kapture.2024-11-29.at.14.58.13.mp4
Best Practices
Click to expand
!when you know that the value can’t benullorundefined).Test specific:
usertofireEvent.