Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PC-32910) feat(Achievements): add achievements tracker #7313

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

mleduc-pass
Copy link
Contributor

@mleduc-pass mleduc-pass commented Nov 30, 2024

Link to JIRA ticket: https://passculture.atlassian.net/browse/PC-32910

Flakiness

If I had to re-run tests in the CI due to flakiness, I add the incident on Notion

Checklist

I have:

  • Made sure my feature is working on web.
  • Made sure my feature is working on mobile (depending on relevance : real or virtual devices)
  • Written unit tests native (and web when implementation is different) for my feature.
  • Added a screenshot for UI tickets or deleted the screenshot section if no UI change
  • If my PR is a bugfix, I add the link of the "résolution de problème sur le bug" on Notion
  • I am aware of all the best practices and respected them.

Screenshots

delete if no UI change

Platform Mockup/Before After
iOS
Android
Phone - Chrome
Desktop - Chrome

Best Practices

Click to expand
  • Remove non-null assertion operators (just like other type assertions, this doesn’t change the runtime behavior of your code, so it’s important to only use ! when you know that the value can’t be null or undefined).

Test specific:

  • When you see a local variable that is over-written in every test, mock it.
  • Prefer user to fireEvent.

@mleduc-pass mleduc-pass force-pushed the PC-32910-add-achievements-tracker branch 2 times, most recently from 2c6b69b to 19378c2 Compare November 30, 2024 12:56
@mleduc-pass mleduc-pass marked this pull request as ready for review November 30, 2024 12:57
@mleduc-pass mleduc-pass force-pushed the PC-32910-add-achievements-tracker branch from 19378c2 to 53495fb Compare November 30, 2024 12:59
@mleduc-pass mleduc-pass force-pushed the PC-32910-add-achievements-tracker branch from 53495fb to 5d1908a Compare November 30, 2024 13:29
Copy link
Contributor

@lbeneston-pass lbeneston-pass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mleduc-pass mleduc-pass merged commit 3637938 into master Dec 2, 2024
53 checks passed
@mleduc-pass mleduc-pass deleted the PC-32910-add-achievements-tracker branch December 2, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants