-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hydropandas extension #130
Conversation
dbrakenhoff
commented
Jul 30, 2024
- methods to quickly add hpd.Obs or hpd.ObsCollection to a pastastore
- some thin wrappers around hydropandas for downloading BRO or KNMI data
- convenient option to update time series currently in store from BRO or KNMI.
- some thin wrappers around hydropandas for downloading BRO or KNMI data - convenient option to update time series currently in store from BRO or KNMI.
Test fails probably because too many connection attempts to KNMI API |
Maybe we can cache this as well? With @lru_chache decorator? |
Not sure what we're testing if we're loading from the cache in a test that wants to download the information :P. But we could rewrite the tests to load from a file. Or very pragmatic, just allow it to fail since it's non-essential to pastastore. That way we can see if it works, but it won't block any PRs etc. |