Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hydropandas extension #130

Merged
merged 7 commits into from
Aug 6, 2024
Merged

Add hydropandas extension #130

merged 7 commits into from
Aug 6, 2024

Conversation

dbrakenhoff
Copy link
Member

  • methods to quickly add hpd.Obs or hpd.ObsCollection to a pastastore
  • some thin wrappers around hydropandas for downloading BRO or KNMI data
  • convenient option to update time series currently in store from BRO or KNMI.

- some thin wrappers around hydropandas for downloading BRO or KNMI data
- convenient option to update time series currently in store from BRO or KNMI.
@dbrakenhoff dbrakenhoff self-assigned this Jul 30, 2024
@dbrakenhoff dbrakenhoff added the enhancement New feature or request label Jul 30, 2024
@dbrakenhoff
Copy link
Member Author

Test fails probably because too many connection attempts to KNMI API

pyproject.toml Show resolved Hide resolved
@martinvonk
Copy link
Contributor

Test fails probably because too many connection attempts to KNMI API

Maybe we can cache this as well? With @lru_chache decorator?

@dbrakenhoff
Copy link
Member Author

Test fails probably because too many connection attempts to KNMI API

Maybe we can cache this as well? With @lru_chache decorator?

Not sure what we're testing if we're loading from the cache in a test that wants to download the information :P. But we could rewrite the tests to load from a file. Or very pragmatic, just allow it to fail since it's non-essential to pastastore. That way we can see if it works, but it won't block any PRs etc.

@dbrakenhoff dbrakenhoff merged commit fa7cee4 into dev Aug 6, 2024
22 checks passed
@dbrakenhoff dbrakenhoff deleted the hpd_extension branch August 6, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants