-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UIKit Nav Cleanup #1102
UIKit Nav Cleanup #1102
Conversation
…ificantly reduce UI logic required under the hood
Independent — actually started this before #1103! |
Update: there's at least two small CSS fixes that'll be needed here before this is good to go in IE 11 + Firefox, FYI! |
It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks! |
@sghoweri just checking in on this - I havent reviewed in quite a while, citing your above comment |
Do you need a review for this topic or is it not finished at the moment? |
packages/uikit-workshop/src/scripts/components/pl-nav/nav-dropdown.scss
Outdated
Show resolved
Hide resolved
packages/uikit-workshop/src/scripts/components/pl-nav/nav-dropdown.scss
Outdated
Show resolved
Hide resolved
packages/uikit-workshop/src/scripts/components/pl-nav/nav-dropdown.scss
Outdated
Show resolved
Hide resolved
packages/uikit-workshop/src/scripts/components/pl-nav/nav-link.scss
Outdated
Show resolved
Hide resolved
packages/uikit-workshop/src/scripts/components/pl-nav/nav-link.scss
Outdated
Show resolved
Hide resolved
It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks! |
It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks! |
* feat: upgrade to Preact v10 * refactor: break apart Nav into smaller more maintainable pieces; significantly reduce UI logic required under the hood * refactor: minor tweaks to Pattern State UI * fix: fix the drag offset of the drawer resizer * chore: update yarn.lock * refactor: rename root Nav component files * pattern-lab#1102 After merge fixes * fix: yarn lock after merge * fix: review findings in css and js * fix: remove unused code and reimplement utility func Co-authored-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com> Co-authored-by: Josef Bredreck <slime.games@outlook.de> Co-authored-by: Josef Bredreck <13408112+JosefBredereck@users.noreply.github.com>
Long overdue front-end cleanup of the Nav component to be more maintainable, more easily updated in the future and more performant. Not 100% where I want to be with this ideally (maybe 80%+) but definitely puts us in a much better spot than before.
At a high level, this includes one new feature, but most of this is just under the hood refactoring.
New Feature (Fix?)
Refactor
I still need to finish up doing cross browser testing on this but early testing seems very promising.
Side Note: I mistakenly branched this off of #1034 so I'd recommend we merge that down first to avoid merge conflicts + reduce any potential rework!