-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Form - Resource name field #4
Comments
It looks like this component was already created in the odh-dashboard repository and is reusable. https://github.com/opendatahub-io/odh-dashboard/blob/main/frontend/src/concepts/k8s/K8sNameDescriptionField/K8sNameDescriptionField.tsx |
@simrandhaliw Would it be OK to add a "Description" text area field as part of this pattern? The current component which is being used in RHOAI is Is it ok to add a Description field? Or is the goal to have a component encapsulating only the Name and Resource name fields? |
This was discussed in Slack, and I'm sharing some notes from the thread here for transparency:
|
🎉 This issue has been resolved in version 1.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Is this a new component or an extension of an existing one?
We already use the 'Resource name' link button in some areas of the UI (e.g., in the project creation modal). However, we want to change how this button is presented and develop a consistent pattern that can be applied wherever it is relevant.
Describe the feature
Are there visuals for this feature? If applicable, please include examples for each state and for varying widths
Here is the link to the guideline document that describes this pattern and provides examples.
Any other information?
For any UX queries regarding this pattern, please contact Kun (Xiankun Li) and Sim Dhaliwal.
The text was updated successfully, but these errors were encountered: