Update to latest Patternfly V6 alphas #201

jeff-phillips-18 · 2024-05-28T14:45:00Z

What

Updates to last Patternfly V6 alpha release.

Type of change

Refactoring (no functional changes, no api changes)

patternfly-build · 2024-05-28T14:46:57Z

Preview: https://react-topology-pr-topology-201.surge.sh

jeff-phillips-18 · 2024-05-28T20:11:15Z

There are 2 commits here:

run the v6 code mods
make fixes to get close

You can look at the second commit to see where the codemods fell short.

jeff-phillips-18 · 2024-05-28T20:12:30Z

Demo app surge: https://v6-updates.surge.sh/

nicolethoen · 2024-06-11T12:45:14Z

@jeff-phillips-18 can I do anything to help move this along?

andrew-ronaldson · 2024-06-21T13:17:05Z

packages/module/src/css/topology-side-bar.css

@@ -9,7 +9,7 @@
  width: 0;
  max-width: 100%;
  height: 100%;
-  background-color: var(--pf-v5-global--BackgroundColor--100);
+  background-color: var(--pf-t--global--background--color--100);


var(--pf-t--global--background--color--primary--default)

andrew-ronaldson · 2024-06-21T13:17:15Z

packages/module/src/css/topology-side-bar.css

@@ -36,7 +36,7 @@
 .pf-topology-resizable-side-bar {
  width: 100%;
  height: 100%;
-  background-color: var(--pf-v5-global--BackgroundColor--100);
+  background-color: var(--pf-t--global--background--color--100);


var(--pf-t--global--background--color--primary--default)

andrew-ronaldson · 2024-06-21T13:17:26Z

packages/module/src/css/topology-side-bar.css

@@ -50,7 +50,7 @@
 @media (min-width: 768px) {
  .pf-topology-container__with-sidebar {
    overflow-x: hidden;
-    background-color: var(--pf-v5-global--Color--light-200) !important;
+    background-color: var(--pf-t--global--background--color--200) !important;


var(--pf-t--global--background--color--secondary--default)

andrew-ronaldson · 2024-06-21T13:18:35Z

packages/module/src/css/topology-controlbar.css

-  bottom: var(--pf-v5-global--spacer--md);
-  left: var(--pf-v5-global--spacer--xl);
+  bottom: 0;
+  left: var(--pf-t--global--spacer--400);


var(--pf-t--global--spacer--lg)

andrew-ronaldson · 2024-06-21T13:25:57Z

packages/module/src/css/topology-controlbar.css

-  margin-right: var(--pf-v5-global--spacer--xs);
-  margin-top: var(--pf-v5-global--spacer--xs);
+.pf-topology-control-bar__button.pf-v6-c-button.pf-m-tertiary {
+  margin-right: var(--pf-t--global--spacer--100);


margin-right: var(--pf-t--global--spacer--gap--control-to-control--default); margin-top: var(--pf-t--global--spacer--xs); padding: var(--pf-t--global--spacer--control--vertical--plain) var(--pf-t--global--spacer--control--horizontal--default);

andrew-ronaldson · 2024-06-21T13:26:53Z

packages/module/src/css/topology-controlbar.css

-.pf-topology-control-bar__button.pf-v5-c-button.pf-m-tertiary:not(.pf-m-disabled) {
-  background-color: var(--pf-v5-global--BackgroundColor--100);
+.pf-topology-control-bar__button.pf-v6-c-button.pf-m-tertiary:not(.pf-m-disabled) {
+  background-color: var(--pf-t--global--background--color--100);


var(--pf-t--global--background--color--primary--default)

jeff-phillips-18 · 2024-06-21T17:20:06Z

@andrew-ronaldson @nicolethoen @jenny-s51 Please take another look. I think this is in good shape now.

Latest surge for Demo app: https://v6-updates.surge.sh/

Surge for Doc app: https://react-topology-pr-topology-201.surge.sh/

…ly#221) fix(pipelines): add correct location, scaling, and anchors for expanded task group's pill labels. (patternfly#10) fix(pipelines): add status prop to group labels update import statement

andrew-ronaldson

Looks good. Saw a couple things in review.

Can you add a border-radius: var(--pf-t--global--border--radius--medium); to the node groupings
When there is a status modifier the node labels drop the status color border on hover.

In pipelines can the expanded task look like this instead of the node group.

jeff-phillips-18 · 2024-06-26T12:00:13Z

@andrew-ronaldson @jenny-s51 Updated. PTAL.

andrew-ronaldson · 2024-06-26T13:09:48Z

Looks good. I still see the hover/selected state bug on the node labels. We can fix that in another PR.

Surge
Status + hover:

Status+Selected + hover:

Figma
Status + hover:

Status + Selected + hover:

jenny-s51

The styles are looking awesome @jeff-phillips-18 ! Just noticing the sidebar example window isn't rendering on the docs site (all the other demos look great) https://react-topology-pr-topology-201.surge.sh/topology/sidebar.

jeff-phillips-18 · 2024-06-26T15:39:22Z

@andrew-ronaldson @jenny-s51 Updated. PTAL.

andrew-ronaldson

Thanks for the updates. Looks good to me

jeff-phillips-18 · 2024-06-26T17:15:10Z

Just noticing the sidebar example window isn't rendering on the docs site (all the other demos look great) https://react-topology-pr-topology-201.surge.sh/topology/sidebar.

@jenny-s51 The docs surge did not get updated. If you run locally you will see this fix.

jenny-s51 · 2024-06-26T17:16:39Z

Sounds good @jeff-phillips-18 pulling it down to take a look

jenny-s51

LGTM 👍

jeff-phillips-18 requested review from nicolethoen, andrew-ronaldson and jenny-s51 May 28, 2024 14:45

jeff-phillips-18 force-pushed the v6-updates branch from 4193bf1 to ad11647 Compare May 28, 2024 20:09

This was referenced May 31, 2024

fix(build): update versions to fix build, style fixes jeff-phillips-18/react-topology#1

Open

[WIP] Update to latest alphas, pull in tokens #191

Closed

jeff-phillips-18 force-pushed the v6-updates branch from ad11647 to 36fe58e Compare June 21, 2024 12:59

jeff-phillips-18 force-pushed the v6 branch from abda779 to 53c86a7 Compare June 21, 2024 13:20

jeff-phillips-18 force-pushed the v6-updates branch from 36fe58e to 9bf6ecb Compare June 21, 2024 13:36

andrew-ronaldson reviewed Jun 21, 2024

View reviewed changes

jeff-phillips-18 force-pushed the v6-updates branch 3 times, most recently from 0d7f99c to dbffd6c Compare June 21, 2024 17:04

jeff-phillips-18 changed the title ~~WIP: updates to v6 classes/tokens to fix visuals broken by the v6 upgrade~~ Update to latest Patternfly V6 alphas Jun 21, 2024

feat(pipelines): add support for custom GroupLabelComponent (patternf…

e41b72a

…ly#221) fix(pipelines): add correct location, scaling, and anchors for expanded task group's pill labels. (patternfly#10) fix(pipelines): add status prop to group labels update import statement

jeff-phillips-18 force-pushed the v6-updates branch from dbffd6c to 8e6ca29 Compare June 24, 2024 19:58

andrew-ronaldson self-requested a review June 25, 2024 13:03

andrew-ronaldson reviewed Jun 25, 2024

View reviewed changes

Update to PF dependencies to latest V6

c7b4c1d

jeff-phillips-18 force-pushed the v6-updates branch 2 times, most recently from b79519b to acd66e4 Compare June 25, 2024 19:06

jeff-phillips-18 mentioned this pull request Jun 25, 2024

Rebase to latest main #224

Closed

jenny-s51 reviewed Jun 26, 2024

View reviewed changes

Apply V6 Code Mods and fix up apps

9223b18

jeff-phillips-18 force-pushed the v6-updates branch from 9af83fa to 9223b18 Compare June 26, 2024 15:36

Merge branch 'v6' into v6-updates

fb5ccbc

andrew-ronaldson approved these changes Jun 26, 2024

View reviewed changes

jenny-s51 approved these changes Jun 26, 2024

View reviewed changes

jeff-phillips-18 merged commit 70c815f into patternfly:v6 Jun 27, 2024
8 checks passed

jeff-phillips-18 added a commit to jeff-phillips-18/react-topology that referenced this pull request Jun 27, 2024

Update to latest Patternfly V6 alphas (patternfly#201)

4a3d11a

nicolethoen mentioned this pull request Jun 28, 2024

topology: Consume v6 alphas and build Penta demo #110

Closed

2 tasks

jenny-s51 mentioned this pull request Aug 14, 2024

Rebase v6 and update to latest alphas #181

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to latest Patternfly V6 alphas #201

Update to latest Patternfly V6 alphas #201

jeff-phillips-18 commented May 28, 2024 •

edited

Loading

patternfly-build commented May 28, 2024 •

edited

Loading

jeff-phillips-18 commented May 28, 2024

jeff-phillips-18 commented May 28, 2024

nicolethoen commented Jun 11, 2024

andrew-ronaldson Jun 21, 2024

andrew-ronaldson Jun 21, 2024

andrew-ronaldson Jun 21, 2024

andrew-ronaldson Jun 21, 2024

andrew-ronaldson Jun 21, 2024

andrew-ronaldson Jun 21, 2024

jeff-phillips-18 commented Jun 21, 2024

andrew-ronaldson left a comment

jeff-phillips-18 commented Jun 26, 2024

andrew-ronaldson commented Jun 26, 2024

jenny-s51 left a comment

jeff-phillips-18 commented Jun 26, 2024

andrew-ronaldson left a comment

jeff-phillips-18 commented Jun 26, 2024

jenny-s51 commented Jun 26, 2024

jenny-s51 left a comment •

edited

Loading

Update to latest Patternfly V6 alphas #201

Update to latest Patternfly V6 alphas #201

Conversation

jeff-phillips-18 commented May 28, 2024 • edited Loading

What

Type of change

patternfly-build commented May 28, 2024 • edited Loading

jeff-phillips-18 commented May 28, 2024

jeff-phillips-18 commented May 28, 2024

nicolethoen commented Jun 11, 2024

andrew-ronaldson Jun 21, 2024

Choose a reason for hiding this comment

andrew-ronaldson Jun 21, 2024

Choose a reason for hiding this comment

andrew-ronaldson Jun 21, 2024

Choose a reason for hiding this comment

andrew-ronaldson Jun 21, 2024

Choose a reason for hiding this comment

andrew-ronaldson Jun 21, 2024

Choose a reason for hiding this comment

andrew-ronaldson Jun 21, 2024

Choose a reason for hiding this comment

jeff-phillips-18 commented Jun 21, 2024

andrew-ronaldson left a comment

Choose a reason for hiding this comment

jeff-phillips-18 commented Jun 26, 2024

andrew-ronaldson commented Jun 26, 2024

jenny-s51 left a comment

Choose a reason for hiding this comment

jeff-phillips-18 commented Jun 26, 2024

andrew-ronaldson left a comment

Choose a reason for hiding this comment

jeff-phillips-18 commented Jun 26, 2024

jenny-s51 commented Jun 26, 2024

jenny-s51 left a comment • edited Loading

Choose a reason for hiding this comment

jeff-phillips-18 commented May 28, 2024 •

edited

Loading

patternfly-build commented May 28, 2024 •

edited

Loading

jenny-s51 left a comment •

edited

Loading