Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pipelines): Add focus on newly expanded/collapsed groups #210

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

jeff-phillips-18
Copy link
Member

What

Closes #206

Description

Adds a feature to focus on a group after it has been expanded or collapsed.

On expand the group will be shown in the view with the graph set to fit around the group so that the entire expansion can be viewed or be zoomed in on to emphasize the group.

On collapse, the view may be zoomed out so as not to show extra white space due to the collapsing of the group and the group will be centered in the view.

Note that a new method centerInView was added to the Graph interface and an optional parameter node to the fit method on the Graph interface. Any application that is current implementing these interfaces without extending the base implementation will need to adjust accordingly.

Type of change

  • Feature

@jeff-phillips-18
Copy link
Member Author

Demo app surge: https://expand-collapse-focus.surge.sh/

@patternfly-build
Copy link

Copy link
Collaborator

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, layout focuses on expanded and collapsed node/group bounds, works as expected.

@jenny-s51 jenny-s51 merged commit 871677a into patternfly:main Jun 3, 2024
8 checks passed
Copy link

github-actions bot commented Jun 3, 2024

🎉 This PR is included in version 5.4.0-prerelease.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pipelines: Add Support to Focus on Bounds of Expanded Group
4 participants