Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(group label): Add ability to center the group's label on the edge #216

Merged

Conversation

jeff-phillips-18
Copy link
Member

What

Closes #205

Description

Adds the centerLabelOnEdge option to DefaultTaskGroup. Setting this to true will ignore the labelPadding parameter and instead align the label such that it is centered on the group's border. The source and target anchors are also adjusted to align with the label position.

Type of change

  • Feature

Screen shots / Gifs for design review

image

@patternfly-build
Copy link

patternfly-build commented Jun 5, 2024

Copy link
Collaborator

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Label positioning in vertical "Pipelines Groups Complex Layout" looks great - just seeing one arrow overlapping the group label in the vertical "Pipeline Groups Layout" example for Task 3-3.

Screenshot 2024-06-05 at 2 55 51 PM

@jeff-phillips-18
Copy link
Member Author

Label positioning in vertical "Pipelines Groups Complex Layout" looks great - just seeing one arrow overlapping the group label in the vertical "Pipeline Groups Layout" example for Task 3-3.

@jenny-s51 Fixed

Copy link
Collaborator

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeff-phillips-18 jeff-phillips-18 merged commit d6479b5 into patternfly:main Jun 11, 2024
8 checks passed
@jeff-phillips-18 jeff-phillips-18 deleted the group-label-position branch June 11, 2024 17:45
Copy link

🎉 This PR is included in version 5.4.0-prerelease.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pipelines: Update Top Label Positioning to Align with Upper Border of Group
3 participants