feat(context menu): Add support to hide the kebab toggle in the context menu #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenny-s51
changed the title
|
The label size for the node will need to handle the kebab menu not being shown:
|
jenny-s51
commented
Nov 11, 2024
There was a problem hiding this comment.
Nice catch @jeff-phillips-18, added a check for hidden to fix the label size.
|
@jenny-s51 I believe |
jenny-s51
force-pushed
the
iss237
branch
2 times, most recently
from
25beed5 to
864a1a7
Compare
Add demo option to hide kebab context menus (#14) add condition to contextSpace to fix label size add check to TaskPill remove hideContextMenuKebab from withContextMenuProps add hideContextMenuKebab to NodeLabelProps to fix error
jeff-phillips-18
approved these changes
Nov 13, 2024
|
Released in v5.4.1 |
7 tasks
jenny-s51
added a commit
to jenny-s51/react-topology
that referenced
this pull request
Dec 4, 2024
…ly#250) Add demo option to hide kebab context menus (#14) add condition to contextSpace to fix label size add check to TaskPill remove hideContextMenuKebab from withContextMenuProps add hideContextMenuKebab to NodeLabelProps to fix error fix styles remove semicolon update info icon color token for drag hint update font-size token
jeff-phillips-18
pushed a commit
that referenced
this pull request
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #237
Description
Adds prop
hideContextMenuKebabto toggle context menu via Shift + Right Click only. cc @ferhoyosTo test:
In
DemoNode.tsx, addhideContextMenuKebabas a prop of theDefaultNodecomponent. In the demo app, go to Topology Package and in the "Node Options" dropdown, check Labels and Context Menus.In
DemoTaskNode.tsx, addhideContextMenuKebabas a prop of theTaskNodecomponent. In the demo app, go to Pipelines -> Task Nodes and select "Context Menus" in the toolbar.Type of change
Screen shots / Gifs for design review