Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(context menu): Add the hideContextMenuKebab option to groups #261

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

jenny-s51
Copy link
Collaborator

What

Closes #254

Description

Adds prop hideContextMenuKebab to toggle context menu via Shift + Right Click only. cc @ferhoyos

To test:

In StyleGroup.tsx, add hideContextMenuKebab as a prop of the DefaultGroup component. In the demo app, go to Styles -> Groups -> Collapsible Groups. Verify the menu kebab is hidden and can be toggled with Shift + Right click.

Type of change

  • Feature
  • Bugfix
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Screen shots / Gifs for design review

Before:
Screenshot 2024-12-03 at 4 02 40 PM

After:
Screenshot 2024-12-03 at 4 02 25 PM

@patternfly-build
Copy link

patternfly-build commented Dec 3, 2024

@jeff-phillips-18
Copy link
Member

@jenny-s51 If we can add:

      onContextMenu={options.contextMenus ? onContextMenu : undefined}
      hideContextMenuKebab={options.hideKebabMenu}

to packages/demo-app-ts/src/demos/topologyPackageDemo/DemoGroup.tsx then we can demo this feature in the Topology Package demo

Copy link
Collaborator Author

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea, thanks @jeff-phillips-18 ! Included your suggestion
Screenshot 2024-12-04 at 5 06 44 PM

@jenny-s51 jenny-s51 merged commit bd2cbfe into patternfly:v5 Dec 5, 2024
8 checks passed
@jenny-s51 jenny-s51 deleted the iss254 branch December 5, 2024 16:36
jenny-s51 added a commit to jenny-s51/react-topology that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants