Skip to content

Commit

Permalink
Attempt to vendor 1Password SDK and install via setup.py
Browse files Browse the repository at this point in the history
  • Loading branch information
paulfioravanti committed Aug 30, 2024
1 parent 336198e commit f47db13
Show file tree
Hide file tree
Showing 5 changed files with 20 additions and 12 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ jobs:
- name: Checkout Repository
uses: actions/checkout@v3

- name: Load SSH key into GitHub for 1Password Python SDK install
uses: webfactory/ssh-agent@v0.9.0
with:
ssh-private-key: ${{ secrets.PLOVER_1PASSWORD_PRIVATE_KEY }}
# - name: Load SSH key into GitHub for 1Password Python SDK install
# uses: webfactory/ssh-agent@v0.9.0
# with:
# ssh-private-key: ${{ secrets.PLOVER_1PASSWORD_PRIVATE_KEY }}

- name: Set up Python
uses: actions/setup-python@v4
Expand All @@ -30,7 +30,7 @@ jobs:
- name: Install Test, Coverage, Lint, Type Checking Dependencies
run: |
python -m pip install --editable ".[test]"
python -m pip install git+ssh://git@github.com/1Password/onepassword-sdk-python.git@v0.1.1
# python -m pip install git+ssh://git@github.com/1Password/onepassword-sdk-python.git@v0.1.1

- name: Run Linter
run: pylint plover_1password
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ jobs:
- name: Clone Repository
uses: actions/checkout@v3

- name: Load SSH key into GitHub for 1Password Python SDK install
uses: webfactory/ssh-agent@v0.9.0
with:
ssh-private-key: ${{ secrets.PLOVER_1PASSWORD_PRIVATE_KEY }}
# - name: Load SSH key into GitHub for 1Password Python SDK install
# uses: webfactory/ssh-agent@v0.9.0
# with:
# ssh-private-key: ${{ secrets.PLOVER_1PASSWORD_PRIVATE_KEY }}

- name: Set up Python
uses: actions/setup-python@v4
Expand All @@ -30,7 +30,7 @@ jobs:
- name: Install Test, Coverage, Lint, Type Checking Dependencies
run: |
python -m pip install --editable ".[test]"
python -m pip install git+ssh://git@github.com/1Password/onepassword-sdk-python.git@v0.1.1
# python -m pip install git+ssh://git@github.com/1Password/onepassword-sdk-python.git@v0.1.1

- name: Run Linter
run: pylint plover_1password
Expand Down
2 changes: 1 addition & 1 deletion plover_1password/__version__.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
"""
Version attribute
"""
__version__ = "0.3.6"
__version__ = "0.3.7"
10 changes: 9 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
#!/usr/bin/env python3

from setuptools import setup
import os

setup()
setup(
# NOTE: Remove this and the vendored file once 1Password SDK is published to
# PyPI.
# REF: https://github.com/1Password/onepassword-sdk-python/issues/107
install_requires = [
f"onepassword @ file://{os.getcwd()}/vendor/onepassword-sdk-python-0.1.1.zip"
]
)
Binary file added vendor/onepassword-sdk-python-0.1.1.zip
Binary file not shown.

0 comments on commit f47db13

Please sign in to comment.