Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clef change in grand staff does not persist to subsequent lines #1041

Open
AGBrown opened this issue Aug 18, 2024 · 1 comment
Open

clef change in grand staff does not persist to subsequent lines #1041

AGBrown opened this issue Aug 18, 2024 · 1 comment

Comments

@AGBrown
Copy link

AGBrown commented Aug 18, 2024

Environment:

  • abcjs 6.4.1
  • tested on and occurs in both chrome (127.0.6533.120 (Official Build) (64-bit) (cohort: Stable) ) and firefox (Version 129.0.1, Build ID 20240812083845)

Issue:

As the title says, if you change clef in the following abc, then it does not persist on subsequent lines:

(expand for test abc).

%abc-2.1

X:0
T:Clef change test
%%barnumbers 1
%%measurenb 0
%%score {R|L}
%%stretchlast 1
Q:"Misterioso" 1/4=80
M:2/4
L:1/4
V:R clef=treble
V:L clef=bass
K:Gmaj
[V:R] x x/ G/ | G2 | G2 | G2 |
[V:L] x x/ z/ | C2 | C2 | C2 |
%
%%vskip 40
[V:R] G2 | G2 | G2 | G2 |
[V:L] C2 | C2 | C2 | [K:clef=treble] C2 |
%
%%vskip 40
[V:R] G2 | G2 | G2 | G2 |]
[V:L] C2 | C2 | C2 | C2 |]

Expected output

The clef change should persist on subsequent lines for the relevant stave.

(e.g. from abc2svg ):

(expand for example of expected rendered output).

image

Actual output:

The clef change does not persist for subsequent lines for the relevant stave.

(expand for actual output image).

image

As you can see, the treble clef is not persisted for the lower staff on the last line. There is also a difference in where the treble clef change is rendered, but I'm not sure this is important.

Other observations

  • The key signature is correct for the original clef, not the one that the stave should have changed to
  • Key signature changes are persisted to subsequent lines, just not clef changes.
(expand for full test tune).

%abc-2.1

X:1
T:Clef and key change test
%%barnumbers 1
%%measurenb 0
%%score {R|L}
%%stretchlast 1
Q:"Misterioso" 1/4=80
M:2/4
L:1/4
V:R clef=treble
V:L clef=bass
K:Gmaj
[V:R] x x/ G/ | G2 | G2 | G2 |
[V:L] x x/ z/ | C2 | C2 | C2 |
%
%%vskip 40
[V:R] G2 | G2 | G2 | [K:Dmaj] G2 |
[V:L] C2 | C2 | C2 | [K:Dmaj] [K:clef=treble] C2 |
%
%%vskip 40
[V:R] G2 | G2 | G2 | G2 |]
[V:L] C2 | C2 | C2 | C2 |]

(expand for rendered image).

image

@paulrosen
Copy link
Owner

Definitely a bug. Thanks for the report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants