Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/v4backend #115

Merged
merged 28 commits into from
Nov 4, 2024
Merged

Feature/v4backend #115

merged 28 commits into from
Nov 4, 2024

Conversation

consolethinks
Copy link
Collaborator

scicat-cli changes to support v4 be (v3 support is dropped by this). Closes #114

consolethinks and others added 18 commits October 1, 2024 17:54
minottic
minottic reviewed Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@minottic minottic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A general comment. Since the Bearer addition is used in multiple places, would it make sense to make it a function for reusability/later changes?

datasetIngestor/checkMetadata.go Show resolved Hide resolved
datasetUtils/getUserInfoFromToken.go Outdated Show resolved Hide resolved
datasetIngestor/ingestDataset_test.go Outdated Show resolved Hide resolved
cmd/commands/commonConstants.go Show resolved Hide resolved
datasetIngestor/checkMetadata.go Show resolved Hide resolved
datasetUtils/createJob.go Outdated Show resolved Hide resolved
cmd/cliutils/transferType.go Show resolved Hide resolved
cmd/commands/datasetRetriever.go Show resolved Hide resolved
datasetUtils/getDatasetDetails.go Outdated Show resolved Hide resolved
datasetIngestor/checkMetadata.go Show resolved Hide resolved
@minottic minottic self-requested a review November 4, 2024 12:27
@consolethinks consolethinks merged commit f2e1a33 into main Nov 4, 2024
3 checks passed
@consolethinks consolethinks deleted the feature/v4backend branch November 4, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minottic minottic minottic approved these changes

@sbliven sbliven Awaiting requested review from sbliven

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

scicat-cli v4 backend support
2 participants
@consolethinks @minottic