Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the nonInteractiveFlag flag in CheckForNewVersion function calls #29

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Use the nonInteractiveFlag flag in CheckForNewVersion function calls #29

merged 2 commits into from
Apr 4, 2024

Conversation

kavir1698
Copy link
Collaborator

close #8

@kavir1698 kavir1698 requested a review from a team April 3, 2024 12:53
minottic
minottic reviewed Apr 3, 2024
View reviewed changes
Copy link
Collaborator

@minottic minottic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! I would add some tests to prove it fixes the issue

@kavir1698 kavir1698 requested a review from minottic April 3, 2024 14:35
minottic
minottic approved these changes Apr 4, 2024
View reviewed changes
Copy link
Collaborator

@minottic minottic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@kavir1698 kavir1698 merged commit ed05baf into main Apr 4, 2024
2 checks passed
@kavir1698 kavir1698 deleted the avoid_new_version_checks_noninteractively branch April 4, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minottic minottic minottic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

datasetArchiver stops despite noninteractive flag
2 participants
@kavir1698 @minottic