-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
credential expiration comes back as numeric Inf (unclassed) #789
Comments
Really sorry about my slow replies. I am currently on holiday. I am guessing the biggest issue with this is if a session token is known i.e. sso, then a refresh session token should be generated by the SDK :) |
In the meantime please feel free to raise any PR if you believe you have a solution for this. I do appreciate PRs as paws is a beast of a SDK package. |
Hi @tyner the Currently it is defaulted as inf to represent the session not expiring. I will add a ticket for refreshing/caching credentials so it doesn't need to hit aws for sso credentails. |
Temporary credential refresh are now supported for sso connections #794 |
Thanks @DyfanJones for looking into this! Note: I don't believe we are using sso for credentials, in case that is relevant. |
We had a user set only these three environment variables:
AWS_ACCESS_KEY_ID
AWS_SECRET_ACCESS_KEY
AWS_SESSION_TOKEN
and then when
paws.common::locate_credentials()
was called, its return hadexpiration
equal to numericInf
(with no class attribute; usually it would havePOSIXct
). I not sure whetherInf
is a valid expiration, but if it is, should it be classed? Conversely, if it is not a valid expiration, should an error/warning be thrown?The use case is if someone is caching the credentials and needs to figure out if the cached credentials are expired.
The text was updated successfully, but these errors were encountered: