-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config flatten #639
Config flatten #639
Conversation
@davidkretch What's your view on this? I am just toying around with this idea so not tied to it as of yet. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #639 +/- ##
==========================================
- Coverage 83.88% 83.66% -0.23%
==========================================
Files 189 195 +6
Lines 12934 13213 +279
==========================================
+ Hits 10850 11054 +204
- Misses 2084 2159 +75 ☔ View full report in Codecov by Sentry. |
After discussion in #421 will go for proposal 1. As it helps with auto-complete when initialising service. svc <- acm(
config = list(),
credentials = list(
creds = list(
access_key_id = "string",
secret_access_key = "string",
session_token = "string"
),
profile = "string"
),
endpoint = "string",
region = "string"
) |
Initial idea for flattening the config list for initialising services (ticket: #421)
proposal 2
Downside:
Doesn't help with auto-complete as the short hand utilises
...
instead of individual parameters.Upside:
Allows the short hand method to keep up to date with any parameters that get added to the paws.common backend.