Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial paginate function #650

Merged
merged 19 commits into from
Jul 31, 2023
Merged

Initial paginate function #650

merged 19 commits into from
Jul 31, 2023

Conversation

DyfanJones
Copy link
Member

@DyfanJones DyfanJones commented Jul 24, 2023

This PR adds the following features:

  • paginate function based off ticket: Add paginators #30
  • re-export paws.common helper functions so that paws.common is not explicitly needed to be called
library(paws.storage)

svc <- s3(confg())

paginate(
    svc$list_objects_v2(Bucket = "made-up")
)

@DyfanJones DyfanJones added this to the paws 0.4.0 milestone Jul 24, 2023
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.21% 🎉

Comparison is base (88f32dd) 83.55% compared to head (9f16a7f) 83.76%.
Report is 1 commits behind head on main.

❗ Current head 9f16a7f differs from pull request most recent head 504e7db. Consider uploading reports for the commit 504e7db to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #650      +/-   ##
==========================================
+ Coverage   83.55%   83.76%   +0.21%     
==========================================
  Files         195      198       +3     
  Lines       13216    13819     +603     
==========================================
+ Hits        11042    11576     +534     
- Misses       2174     2243      +69     

see 42 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This was linked to issues Jul 24, 2023
@DyfanJones DyfanJones self-assigned this Jul 24, 2023
@DyfanJones DyfanJones added the enhancement 💡 New feature or request label Jul 24, 2023
@DyfanJones
Copy link
Member Author

I believe we are at a good point. All paginate information is passed from json file to paws so that we can build paginate queries correctly instead of guessing them. Next step will be to add unit tests.

@DyfanJones DyfanJones marked this pull request as ready for review July 31, 2023 15:23
@DyfanJones DyfanJones merged commit f29c71d into paws-r:main Jul 31, 2023
3 checks passed
@edgBR
Copy link

edgBR commented Jul 31, 2023

Hi,

I am no longer using paws but wow, this is a great PR

@DyfanJones DyfanJones deleted the paginate branch September 11, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 💡 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow list_objects_v2 to retrieve >1,000 Keys Add paginators
2 participants