Steven PR feedback: change back CardClientError.canceled to .threeDSe…

…cureCanceled
paypal · Nov 7, 2024 · 83270ee · 83270ee
1 parent 986eabd
commit 83270ee
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/Sources/CardPayments/CardClient.swift b/Sources/CardPayments/CardClient.swift
@@ -170,7 +170,7 @@ public class CardClient: NSObject {
                 if let error = error {
                     switch error {
                     case ASWebAuthenticationSessionError.canceledLogin:
-                        self.notifyCheckoutCancelWithError(with: CardClientError.canceled, completion: completion)
+                        self.notifyCheckoutCancelWithError(with: CardClientError.threeDSecureCanceled, completion: completion)
                         return
                     default:
                         self.notifyCheckoutFailure(with: CardClientError.threeDSecureError(error), completion: completion)
@@ -206,7 +206,7 @@ public class CardClient: NSObject {
                 if let error = error {
                     switch error {
                     case ASWebAuthenticationSessionError.canceledLogin:
-                        self.notifyVaultCancelWithError(with: CardClientError.canceled, completion: completion)
+                        self.notifyVaultCancelWithError(with: CardClientError.threeDSecureCanceled, completion: completion)
                         return
                     default:
                         self.notifyVaultFailure(with: CardClientError.threeDSecureError(error), completion: completion)

diff --git a/Sources/CardPayments/CardClientError.swift b/Sources/CardPayments/CardClientError.swift
@@ -39,7 +39,7 @@ enum CardClientError {
         case malformedDeeplinkURLError
 
         /// 10. Cancellation from 3DS verification
-        case canceledError
+        case threeDSCancellationError
     }
 
     static let unknownError = CoreSDKError(
@@ -68,8 +68,8 @@ enum CardClientError {
         errorDescription: "An invalid 3DS URL was returned. Contact developer.paypal.com/support."
     )
 
-    static let canceled = CoreSDKError(
-        code: Code.canceledError.rawValue,
+    static let threeDSecureCanceled = CoreSDKError(
+        code: Code.threeDSCancellationError.rawValue,
         domain: domain,
         errorDescription: "3DS verification has been canceled by the user."
     )

diff --git a/UnitTests/CardPaymentsTests/CardClient_Tests.swift b/UnitTests/CardPaymentsTests/CardClient_Tests.swift
@@ -203,8 +203,8 @@ class CardClient_Tests: XCTestCase {
             XCTAssertNil(result)
             if let error = error as? CoreSDKError {
                 XCTAssertEqual(error.domain, CardClientError.domain)
-                XCTAssertEqual(error.code, CardClientError.Code.canceledError.rawValue)
-                XCTAssertEqual(error.localizedDescription, CardClientError.canceled.localizedDescription)
+                XCTAssertEqual(error.code, CardClientError.Code.threeDSCancellationError.rawValue)
+                XCTAssertEqual(error.localizedDescription, CardClientError.threeDSecureCanceled.localizedDescription)
             } else {
                 XCTFail("Expected error to be of type CoreSDKError")
             }
@@ -361,8 +361,8 @@ class CardClient_Tests: XCTestCase {
             XCTAssertNil(result)
             if let error = error as? CoreSDKError {
                 XCTAssertEqual(error.domain, CardClientError.domain)
-                XCTAssertEqual(error.code, CardClientError.canceled.code)
-                XCTAssertEqual(error.localizedDescription, CardClientError.canceled.localizedDescription)
+                XCTAssertEqual(error.code, CardClientError.threeDSecureCanceled.code)
+                XCTAssertEqual(error.localizedDescription, CardClientError.threeDSecureCanceled.localizedDescription)
             } else {
                 XCTFail("Expected error to be of type CoreSDKError")
             }