Fix Lint Errors (#277)

* fix linter for redundant_void_return * disable rule non_optional_string_data_conversion
paypal · Jun 6, 2024 · 93c59e9 · 93c59e9
1 parent b46f71d
commit 93c59e9
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/.swiftlint.yml b/.swiftlint.yml
@@ -13,6 +13,7 @@ disabled_rules:
   - type_name # tests will have have the format <SUT>_Tests
   - xctfail_message
   - blanket_disable_command
+  - non_optional_string_data_conversion
 
 opt_in_rules:
   - array_init

diff --git a/UnitTests/CardPaymentsTests/CardClient_Tests.swift b/UnitTests/CardPaymentsTests/CardClient_Tests.swift
@@ -183,8 +183,8 @@ class CardClient_Tests: XCTestCase {
                 expectation.fulfill()
             },
             cancel: { _ in XCTFail("Invoked cancel() callback. Should invoke success().") },
-            threeDSWillLaunch: { _ -> Void in XCTAssert(true) },
-            threeDSLaunched: { _ -> Void in XCTAssert(true) }
+            threeDSWillLaunch: { _ in XCTAssert(true) },
+            threeDSLaunched: { _ in XCTAssert(true) }
         )
 
         sut.vaultDelegate = mockCardVaultDelegate
@@ -291,7 +291,7 @@ class CardClient_Tests: XCTestCase {
 
         let expectation = expectation(description: "approveOrder() completed")
 
-        let mockCardDelegate = MockCardDelegate(success: {_, result -> Void in
+        let mockCardDelegate = MockCardDelegate(success: {_, result in
             XCTAssertEqual(result.orderID, "testOrderId")
             XCTAssertEqual(result.status, "APPROVED")
             XCTAssertFalse(result.didAttemptThreeDSecureAuthentication)
@@ -313,7 +313,7 @@ class CardClient_Tests: XCTestCase {
 
         let expectation = expectation(description: "approveOrder() completed")
 
-        let mockCardDelegate = MockCardDelegate(success: {_, _ -> Void in
+        let mockCardDelegate = MockCardDelegate(success: {_, _ in
             XCTFail("Invoked success() callback. Should invoke error().")
         }, error: { _, error in
             XCTAssertEqual(error.domain, "sdk-domain")
@@ -339,7 +339,7 @@ class CardClient_Tests: XCTestCase {
 
         let expectation = expectation(description: "approveOrder() completed")
 
-        let mockCardDelegate = MockCardDelegate(success: {_, _ -> Void in
+        let mockCardDelegate = MockCardDelegate(success: {_, _ in
             XCTFail("Invoked success() callback. Should invoke error().")
         }, error: { _, error in
             XCTAssertEqual(error.domain, CardClientError.domain)
@@ -375,8 +375,8 @@ class CardClient_Tests: XCTestCase {
                 expectation.fulfill()
             },
             cancel: { _ in XCTFail("Invoked cancel() callback. Should invoke success().") },
-            threeDSWillLaunch: { _ -> Void in XCTAssert(true) },
-            threeDSLaunched: { _ -> Void in XCTAssert(true) })
+            threeDSWillLaunch: { _ in XCTAssert(true) },
+            threeDSLaunched: { _ in XCTAssert(true) })
 
         sut.delegate = mockCardDelegate
         sut.approveOrder(request: cardRequest)