feat: update modal logo a11y (#1009)

paypal · Oct 30, 2023 · 03bfc6c · 03bfc6c
1 parent d762500
commit 03bfc6c
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/src/components/modal/v2/parts/Header.jsx b/src/components/modal/v2/parts/Header.jsx
@@ -44,7 +44,7 @@ const Header = ({
             </div>
             <div className="header__icons">
                 <div className={`logo__wrapper ${isScrolled ? 'logo__wrapper--scroll' : ''}`}>
-                    <div className="pp-logo" alt="PayPal">
+                    <div className="pp-logo">
                         <Icon name={logo} />
                     </div>
                 </div>

diff --git a/src/components/modal/v2/parts/Icon.jsx b/src/components/modal/v2/parts/Icon.jsx
@@ -10,7 +10,16 @@ const Icon = ({ name = '', color, content }) => {
     switch (name) {
         case 'logo':
             return (
-                <svg width="45" height="45" viewBox="0 0 258 258" fill="none" xmlns="http://www.w3.org/2000/svg">
+                <svg
+                    role="img"
+                    aria-label="PayPal"
+                    width="45"
+                    height="45"
+                    viewBox="0 0 258 258"
+                    fill="none"
+                    xmlns="http://www.w3.org/2000/svg"
+                >
+                    <title>PayPal</title>
                     <path
                         d="M190.709 84.0373C191.182 59.4578 170.902 40.5938 143.016 40.5938H85.3376C83.9939 40.594 82.6944 41.0737 81.6729 41.9467C80.6514 42.8197 79.975 44.0286 79.7654 45.3558L56.6551 189.763C56.5517 190.418 56.5913 191.086 56.7713 191.724C56.9513 192.361 57.2673 192.952 57.6976 193.456C58.1278 193.96 58.6622 194.364 59.2638 194.641C59.8654 194.919 60.5199 195.062 61.1823 195.062H95.353L90.0133 228.507C89.9103 229.161 89.9502 229.83 90.1303 230.467C90.3105 231.104 90.6265 231.695 91.0568 232.198C91.487 232.702 92.0212 233.106 92.6227 233.383C93.2241 233.66 93.8784 233.804 94.5406 233.804H122.377C123.72 233.804 124.918 233.324 125.939 232.451C126.961 231.578 127.127 230.369 127.336 229.042L135.506 180.965C135.715 179.638 136.391 177.918 137.413 177.044C138.434 176.171 139.326 175.691 140.67 175.69H157.705C185.013 175.69 208.185 156.28 212.421 129.283C215.418 110.118 207.202 92.6834 190.709 84.0373Z"
                         fill="#001C64"