From ef9f9d88600fe0d82f77e1e354e0a483aee54b20 Mon Sep 17 00:00:00 2001 From: "Erika Colette - NYC (she/her)" <72584889+erikacolette29@users.noreply.github.com> Date: Tue, 19 Nov 2024 15:41:56 -0500 Subject: [PATCH 1/4] ci: update playwright automated tests to run on all PRs (#1158) --- .github/workflows/playwright.yml | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/.github/workflows/playwright.yml b/.github/workflows/playwright.yml index 930d995b34..0074458f68 100644 --- a/.github/workflows/playwright.yml +++ b/.github/workflows/playwright.yml @@ -2,10 +2,7 @@ name: Playwright Accessibility Tests on: # allow for manual triggers workflow_dispatch: {} - push: - branches: [playwright-automated-testing] - pull_request: - branches: [playwright-automated-testing] + pull_request: {} jobs: test: timeout-minutes: 60 @@ -32,4 +29,4 @@ jobs: with: name: playwright-report path: playwright-report/ - retention-days: 1 \ No newline at end of file + retention-days: 1 From b58a8af1856308fd18db26a4eec7b296aca37622 Mon Sep 17 00:00:00 2001 From: "Erika Colette - NYC (she/her)" <72584889+erikacolette29@users.noreply.github.com> Date: Mon, 2 Dec 2024 14:24:42 -0500 Subject: [PATCH 2/4] styles update for firefox issue --- .../modal/v2/styles/components/_offer-accordion.scss | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/components/modal/v2/styles/components/_offer-accordion.scss b/src/components/modal/v2/styles/components/_offer-accordion.scss index 0652506106..b70e04f61c 100644 --- a/src/components/modal/v2/styles/components/_offer-accordion.scss +++ b/src/components/modal/v2/styles/components/_offer-accordion.scss @@ -1,3 +1,5 @@ +@import '../globals/mixins'; + .accordion { &__container { border: 1px solid $light-gray; @@ -81,6 +83,9 @@ display: flex; justify-content: space-between; padding: 25px 18px 0px 13px; + @include smallMobile { + padding-top: 22px; + } &:first-child { padding-top: 0px; From aa9bc6d697cb396362dfc1024bf88d9cea4ec6a2 Mon Sep 17 00:00:00 2001 From: "Erika Colette - NYC (she/her)" <72584889+erikacolette29@users.noreply.github.com> Date: Mon, 2 Dec 2024 14:37:12 -0500 Subject: [PATCH 3/4] spacing styles --- src/components/modal/v2/styles/components/_offer-accordion.scss | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/components/modal/v2/styles/components/_offer-accordion.scss b/src/components/modal/v2/styles/components/_offer-accordion.scss index b70e04f61c..8945878e0f 100644 --- a/src/components/modal/v2/styles/components/_offer-accordion.scss +++ b/src/components/modal/v2/styles/components/_offer-accordion.scss @@ -83,9 +83,11 @@ display: flex; justify-content: space-between; padding: 25px 18px 0px 13px; + @include smallMobile { padding-top: 22px; } + &:first-child { padding-top: 0px; From 5805b1211daa2814c71e0d5be2bc3be768d96be8 Mon Sep 17 00:00:00 2001 From: "Erika Colette - NYC (she/her)" <72584889+erikacolette29@users.noreply.github.com> Date: Tue, 3 Dec 2024 11:24:06 -0500 Subject: [PATCH 4/4] min width modal, increase smallmobile height, fix link text not wrapping --- src/components/modal/v2/parts/views/LongTerm/styles.scss | 1 - .../modal/v2/styles/components/_body-content.scss | 3 +++ .../modal/v2/styles/components/_offer-accordion.scss | 8 ++++---- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/src/components/modal/v2/parts/views/LongTerm/styles.scss b/src/components/modal/v2/parts/views/LongTerm/styles.scss index 96d6c9a381..f8956a2645 100644 --- a/src/components/modal/v2/parts/views/LongTerm/styles.scss +++ b/src/components/modal/v2/parts/views/LongTerm/styles.scss @@ -21,7 +21,6 @@ } .nav__link-prefix { - min-width: 315px; padding: 0px; font-size: 14px; margin: 0px; diff --git a/src/components/modal/v2/styles/components/_body-content.scss b/src/components/modal/v2/styles/components/_body-content.scss index 55b2a727b4..547b8831d2 100644 --- a/src/components/modal/v2/styles/components/_body-content.scss +++ b/src/components/modal/v2/styles/components/_body-content.scss @@ -76,6 +76,9 @@ @include desktop { max-height: 90vh; } + @include mobile { + min-width: 285px; + } @include lander { height: auto; diff --git a/src/components/modal/v2/styles/components/_offer-accordion.scss b/src/components/modal/v2/styles/components/_offer-accordion.scss index 8945878e0f..ad4ce5220f 100644 --- a/src/components/modal/v2/styles/components/_offer-accordion.scss +++ b/src/components/modal/v2/styles/components/_offer-accordion.scss @@ -77,6 +77,10 @@ .open & { height: 172px; transition: height 0.2s linear; + + @include smallMobile { + height: 190px; + } } .accordion__row { @@ -84,10 +88,6 @@ justify-content: space-between; padding: 25px 18px 0px 13px; - @include smallMobile { - padding-top: 22px; - } - &:first-child { padding-top: 0px;